Skip to content

RDKE-1066: metaChanges-donotomerge-8.5_2 #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PreethiLakshmi91 wants to merge 1 commit into
base: support/8.5.3.0
Choose a base branch
from
Open

RDKE-1066: metaChanges-donotomerge-8.5_2 #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions conf/machine/include/middleware.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ RDK_MW_ARCH ??= "${MACHINE}"
MIDDLEWARE_ARCH = "${RDK_MW_ARCH}-middleware"
PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}"

RELEASE_NUM = "8.5.3.0"
RELEASE_NUM = "RDKE-1066_17A1"
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RELEASE_NUM is now set to a ticket/build identifier ("RDKE-1066_17A1"). Because this value is embedded into the feed URL, hardcoding a non-version string here makes the config branch-specific and easy to forget to revert, which can break consumers expecting a stable release layout. Consider keeping a version-like default and/or making this value overrideable via a separate variable (e.g., a CI-provided tag) rather than committing a ticket-specific value.

Copilot uses AI. Check for mistakes.

MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}"
MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}"
Comment on lines +8 to +10
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions fixing message_filter traversal, but this diff only changes middleware IPK feed configuration (RELEASE_NUM and middleware-*/ paths). Please update the PR description (or include the missing code changes) so reviewers can validate the intended behavior and risk accurately.

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching the default feed path from middleware-rel to middleware-dbg changes where OPKG will fetch middleware packages for all builds using this include. If middleware-dbg is intended only for specific debug/test builds, consider making this conditional (e.g., based on BUILD_VARIANT or an explicit feature flag) so release builds don’t unintentionally consume debug artifacts.

Suggested change
MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}"
MW_IPK_PATH ?= "${@('middleware-dbg' if d.getVar('BUILD_VARIANT') == 'dbg' else 'middleware-rel') + '/' + d.getVar('RELEASE_NUM')}"

Copilot uses AI. Check for mistakes.
MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_IPK_PATH}/${RDK_MW_ARCH}/ipks/${BUILD_VARIANT}"

IPK_FEED_URIS += " \
Expand Down
2 changes: 1 addition & 1 deletion conf/machine/include/oss_mw.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ MW_EXTENSION = "-middleware"
MW_OSS = "${@get_oss_arch(d)}${MW_EXTENSION}"
PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} "
OPKG_ARCH_PRIORITY:${MW_OSS} = "205"
MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}"
MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}"
Copy link

Copilot AI Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This changes the OSS middleware feed path from middleware-rel to middleware-dbg. If middleware-dbg is not meant to be the default for all builds (including non-debug variants), consider gating this selection behind a build flag/variant to avoid pulling unintended artifacts at runtime.

Suggested change
MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}"
MW_OSS_IPK_PATH ?= "${@('middleware-dbg/%s' if (d.getVar('BUILD_VARIANT') or '').lower() in ('dbg', 'debug') else 'middleware-rel/%s') % d.getVar('RELEASE_NUM')}"

Copilot uses AI. Check for mistakes.
MW_OSS_IPK_SERVER_PATH = "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/${BUILD_VARIANT}"
IPK_FEED_URIS += " ${MW_OSS}##${MW_OSS_IPK_SERVER_PATH} "
Loading