Feature/rdkemw 17411 ref#97
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the middleware IPK feed configuration to consume artifacts from a new reference tag and path, impacting where Yocto/OPKG will fetch middleware (and OSS middleware) packages from.
Changes:
- Set
RELEASE_NUMtoRDKEMW-17411_refin middleware configuration. - Switch middleware IPK feed paths from
middleware-rel/...tomiddleware-dbg/...for both standard and OSS middleware feeds.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
conf/machine/include/middleware.inc |
Updates RELEASE_NUM and the default middleware IPK feed path used to construct IPK_FEED_URIS. |
conf/machine/include/oss_mw.inc |
Updates the OSS middleware IPK feed path used to construct the OSS IPK_FEED_URIS entry. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| OPKG_ARCH_PRIORITY:${MW_OSS} = "205" | ||
| MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | ||
| MW_OSS_IPK_SERVER_PATH = "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/${BUILD_VARIANT}" |
There was a problem hiding this comment.
MW_OSS_IPK_SERVER_PATH is assigned with = (non-overridable), while the non-OSS path uses ?= in middleware.inc. This makes it hard for downstream configs to redirect the OSS feed (e.g., to a different artifacts base URL/path) without patching this layer. Consider switching this to ?= for consistency and configurability.
| MW_OSS_IPK_SERVER_PATH = "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/${BUILD_VARIANT}" | |
| MW_OSS_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/${BUILD_VARIANT}" |
| @@ -5,9 +5,9 @@ RDK_MW_ARCH ??= "${MACHINE}" | |||
| MIDDLEWARE_ARCH = "${RDK_MW_ARCH}-middleware" | |||
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | |||
|
|
|||
There was a problem hiding this comment.
RELEASE_NUM is now set to RDKEMW-17411_ref, but the repository CHANGELOG’s latest section is still 8.5.3.0. If RELEASE_NUM is intended to represent the middleware release version, this creates a documentation mismatch; either update the changelog to match, or clarify (e.g., via naming/comment) that RELEASE_NUM is an artifacts tag/branch identifier rather than the product version.
| # Artifact tag used to locate/publish middleware IPKs; this is not the | |
| # middleware product release version reflected in the repository CHANGELOG. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| RELEASE_NUM = "RDKEMW-17411_Ref" | ||
|
|
||
| MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}" | ||
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" |
There was a problem hiding this comment.
MW_IPK_PATH is switched from "middleware-rel" to "middleware-dbg", which means the build will pull middleware IPKs from the debug feed by default. Given this layer is named "middleware-release" (conf/layer.conf), this looks like an unintended operational change for release builds; consider keeping the default on the release feed and gating debug feeds behind an explicit opt-in (e.g., a DISTRO_FEATURE/variable override).
| MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}" | |
| MW_IPK_FEED ?= "middleware-rel" | |
| MW_IPK_PATH ?= "${MW_IPK_FEED}/${RELEASE_NUM}" |
| PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}" | ||
|
|
||
| RELEASE_NUM = "8.5.3.0" | ||
| RELEASE_NUM = "RDKEMW-17411_Ref" |
There was a problem hiding this comment.
RELEASE_NUM is hard-assigned to a ticket-specific value ("RDKEMW-17411_Ref"), which will override any upstream/local configuration and force all builds that include this file to use that feed path. To keep this configurable (similar to RDK_MW_ARCH ??= and MW_IPK_PATH ?=), set RELEASE_NUM with a weak/default assignment and override it from the build configuration when needed.
| RELEASE_NUM = "RDKEMW-17411_Ref" | |
| RELEASE_NUM ?= "RDKEMW-17411_Ref" |
No description provided.