Skip to content

Feature/rdkemw 17411 ref #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
varatharajan568 wants to merge 4 commits into
base: develop
Choose a base branch
from
+3 −3
Open

Feature/rdkemw 17411 ref #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
440406a
Update middleware.inc
varatharajan568 Apr 21, 2026
58f4811
Update oss_mw.inc
varatharajan568 Apr 21, 2026
97d9a85
Update middleware.inc
varatharajan568 Apr 21, 2026
67eb6b4
Update middleware.inc
varatharajan568 Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions conf/machine/include/middleware.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,9 @@ RDK_MW_ARCH ??= "${MACHINE}"
MIDDLEWARE_ARCH = "${RDK_MW_ARCH}-middleware"
PACKAGE_EXTRA_ARCHS:append = " ${MIDDLEWARE_ARCH}"

Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RELEASE_NUM is now set to RDKEMW-17411_ref, but the repository CHANGELOG’s latest section is still 8.5.3.0. If RELEASE_NUM is intended to represent the middleware release version, this creates a documentation mismatch; either update the changelog to match, or clarify (e.g., via naming/comment) that RELEASE_NUM is an artifacts tag/branch identifier rather than the product version.

Suggested change
# Artifact tag used to locate/publish middleware IPKs; this is not the
# middleware product release version reflected in the repository CHANGELOG.

Copilot uses AI. Check for mistakes.
RELEASE_NUM = "8.5.3.0"
RELEASE_NUM = "RDKEMW-17411_Ref"
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RELEASE_NUM is hard-assigned to a ticket-specific value ("RDKEMW-17411_Ref"), which will override any upstream/local configuration and force all builds that include this file to use that feed path. To keep this configurable (similar to RDK_MW_ARCH ??= and MW_IPK_PATH ?=), set RELEASE_NUM with a weak/default assignment and override it from the build configuration when needed.

Suggested change
RELEASE_NUM = "RDKEMW-17411_Ref"
RELEASE_NUM ?= "RDKEMW-17411_Ref"

Copilot uses AI. Check for mistakes.

MW_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}"
MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}"
Copy link

Copilot AI Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MW_IPK_PATH is switched from "middleware-rel" to "middleware-dbg", which means the build will pull middleware IPKs from the debug feed by default. Given this layer is named "middleware-release" (conf/layer.conf), this looks like an unintended operational change for release builds; consider keeping the default on the release feed and gating debug feeds behind an explicit opt-in (e.g., a DISTRO_FEATURE/variable override).

Suggested change
MW_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}"
MW_IPK_FEED ?= "middleware-rel"
MW_IPK_PATH ?= "${MW_IPK_FEED}/${RELEASE_NUM}"

Copilot uses AI. Check for mistakes.
MW_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_IPK_PATH}/${RDK_MW_ARCH}/ipks/${BUILD_VARIANT}"

IPK_FEED_URIS += " \
Expand Down
2 changes: 1 addition & 1 deletion conf/machine/include/oss_mw.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,6 @@ MW_EXTENSION = "-middleware"
MW_OSS = "${@get_oss_arch(d)}${MW_EXTENSION}"
PACKAGE_EXTRA_ARCHS:append = " ${MW_OSS} "
OPKG_ARCH_PRIORITY:${MW_OSS} = "205"
MW_OSS_IPK_PATH ?= "middleware-rel/${RELEASE_NUM}"
MW_OSS_IPK_PATH ?= "middleware-dbg/${RELEASE_NUM}"
MW_OSS_IPK_SERVER_PATH = "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/${BUILD_VARIANT}"
Copy link

Copilot AI Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MW_OSS_IPK_SERVER_PATH is assigned with = (non-overridable), while the non-OSS path uses ?= in middleware.inc. This makes it hard for downstream configs to redirect the OSS feed (e.g., to a different artifacts base URL/path) without patching this layer. Consider switching this to ?= for consistency and configurability.

Suggested change
MW_OSS_IPK_SERVER_PATH = "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/${BUILD_VARIANT}"
MW_OSS_IPK_SERVER_PATH ?= "${RDK_ARTIFACTS_BASE_URL}/${MW_OSS_IPK_PATH}/${RDK_MW_ARCH}/${MW_OSS}/ipks/${BUILD_VARIANT}"

Copilot uses AI. Check for mistakes.
IPK_FEED_URIS += " ${MW_OSS}##${MW_OSS_IPK_SERVER_PATH} "
Loading