RDK-60808-service: devicediagnostics plugin service file added#180
RDK-60808-service: devicediagnostics plugin service file added#180dnnaveen151027 wants to merge 1 commit intodevelopfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Pull request overview
Adds a new systemd oneshot unit to activate the WPEFramework DeviceDiagnostics plugin after wpeframework.service has started (gated by /tmp/wpeframeworkstarted).
Changes:
- Introduces
wpeframework-devicediagnostics.servicesystemd unit. - Configures it as a
oneshotservice using/usr/bin/PluginActivator org.rdk.DeviceDiagnostics.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,9 @@ | |||
| [Unit] | |||
| Description=WPE DeviceDiagnostics | |||
There was a problem hiding this comment.
Description line is inconsistent with the established naming used by other WPEFramework plugin unit files (typically "Description=WPEFramework Initialiser"). For consistency and easier service identification (e.g., in systemctl list-units), consider updating this to match the pattern (e.g., include the "WPEFramework" prefix and "Initialiser").
| Description=WPE DeviceDiagnostics | |
| Description=WPEFramework DeviceDiagnostics Initialiser |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [Service] | ||
| Type=oneshot | ||
| RemainAfterExit=yes | ||
| ExecStart=/usr/bin/PluginActivator org.rdk.DeviceDiagnostics |
There was a problem hiding this comment.
The file is missing a trailing blank line at the end. All other service files in the repository follow the convention of having a blank line after the ExecStart line (see wpeframework-analytics.service, wpeframework-bluetooth.service, wpeframework-deviceinfo.service, wpeframework-monitor.service, wpeframework-system.service, wpeframework-telemetry.service, etc.). This helps maintain consistent formatting across all service files.
| ExecStart=/usr/bin/PluginActivator org.rdk.DeviceDiagnostics | |
| ExecStart=/usr/bin/PluginActivator org.rdk.DeviceDiagnostics |
dnnaveen151027
force-pushed
the
topic/RDK-60808-service
branch
from
1f612ae to
61d0407
Compare
|
recheck |
|
@copilot can you recheck the cla failure now i have added the email and user name properly |
|
@dnnaveen151027 I've opened a new pull request, #181, to work on those changes. Once the pull request is ready, I'll request review from you. |
dnnaveen151027
changed the title
|
I have read the CLA Document and I hereby sign the CLA |
1 similar comment
|
I have read the CLA Document and I hereby sign the CLA |
No description provided.