Skip to content

RDK-60808-service: devicediagnostics plugin service file added #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnnaveen151027 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

RDK-60808-service: devicediagnostics plugin service file added #180

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions systemd/system/wpeframework-devicediagnostics.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
[Unit]
Description=WPE DeviceDiagnostics
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description line is inconsistent with the established naming used by other WPEFramework plugin unit files (typically "Description=WPEFramework Initialiser"). For consistency and easier service identification (e.g., in systemctl list-units), consider updating this to match the pattern (e.g., include the "WPEFramework" prefix and "Initialiser").

Suggested change
Description=WPE DeviceDiagnostics
Description=WPEFramework DeviceDiagnostics Initialiser

Copilot uses AI. Check for mistakes.
Requires=wpeframework.service
After=wpeframework.service
ConditionPathExists=/tmp/wpeframeworkstarted
[Service]
Type=oneshot
RemainAfterExit=yes
ExecStart=/usr/bin/PluginActivator org.rdk.DeviceDiagnostics
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file is missing a trailing blank line at the end. All other service files in the repository follow the convention of having a blank line after the ExecStart line (see wpeframework-analytics.service, wpeframework-bluetooth.service, wpeframework-deviceinfo.service, wpeframework-monitor.service, wpeframework-system.service, wpeframework-telemetry.service, etc.). This helps maintain consistent formatting across all service files.

Suggested change
ExecStart=/usr/bin/PluginActivator org.rdk.DeviceDiagnostics
ExecStart=/usr/bin/PluginActivator org.rdk.DeviceDiagnostics

Copilot uses AI. Check for mistakes.