RDK-60808: systemd service file added for devicediagnostics plugin#182
RDK-60808: systemd service file added for devicediagnostics plugin#182dnnaveen151027 wants to merge 1 commit intodevelopfrom
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
There was a problem hiding this comment.
Pull request overview
Adds a new systemd unit to activate the WPEFramework DeviceDiagnostics plugin as part of the existing plugin-startup service pattern.
Changes:
- Introduces
wpeframework-devicediagnostics.serviceto runPluginActivator org.rdk.DeviceDiagnosticsas a oneshot service. - Hooks startup ordering to
wpeframework.serviceand gates activation on/tmp/wpeframeworkstarted.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,10 @@ | |||
|
|
|||
There was a problem hiding this comment.
The file starts with a leading blank line. Most existing WPEFramework plugin unit files start directly with the [Unit] header (no preceding empty line), so this should be removed to keep formatting consistent and avoid accidental whitespace diffs.
| @@ -0,0 +1,10 @@ | |||
|
|
|||
| [Unit] | |||
| Description=WPE DeviceDiagnostics | |||
There was a problem hiding this comment.
Description deviates from the established pattern used by other plugin activator units (e.g., "WPEFramework Initialiser"). Consider updating it to match so that systemctl listings remain consistent and searchable across plugins.
| Description=WPE DeviceDiagnostics | |
| Description=WPEFramework DeviceDiagnostics Initialiser |
|
I have read the CLA Document and I hereby sign the CLA |
No description provided.