Skip to content

RDK-60808: systemd service file added for devicediagnostics plugin #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnnaveen151027 wants to merge 1 commit into
base: develop
Choose a base branch
from
+10 −0
Open

RDK-60808: systemd service file added for devicediagnostics plugin #182

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions systemd/system/wpeframework-devicediagnostics.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@

Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file starts with a leading blank line. Most existing WPEFramework plugin unit files start directly with the [Unit] header (no preceding empty line), so this should be removed to keep formatting consistent and avoid accidental whitespace diffs.

Suggested change

Copilot uses AI. Check for mistakes.
[Unit]
Description=WPE DeviceDiagnostics
Copy link

Copilot AI Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Description deviates from the established pattern used by other plugin activator units (e.g., "WPEFramework Initialiser"). Consider updating it to match so that systemctl listings remain consistent and searchable across plugins.

Suggested change
Description=WPE DeviceDiagnostics
Description=WPEFramework DeviceDiagnostics Initialiser

Copilot uses AI. Check for mistakes.
Requires=wpeframework.service
After=wpeframework.service
ConditionPathExists=/tmp/wpeframeworkstarted
[Service]
Type=oneshot
RemainAfterExit=yes
ExecStart=/usr/bin/PluginActivator org.rdk.DeviceDiagnostics