RDK-60812: powermanager service trigger removed#190
RDK-60812: powermanager service trigger removed#190dnnaveen151027 wants to merge 3 commits intodevelopfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR disables the PowerManager plugin activation trigger in its systemd service file, replacing the PluginActivator call with a no-op echo command. This is described as removing the "powermanager service trigger" per ticket RDK-60812.
Changes:
ExecStartinwpeframework-powermanager.servicechanged from/usr/bin/PluginActivator org.rdk.PowerManagerto/bin/echo "pluginactivator disabled for powermanager", effectively preventing the PowerManager plugin from being activated at boot.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| Type=oneshot | ||
| RemainAfterExit=yes | ||
| ExecStart=/usr/bin/PluginActivator org.rdk.PowerManager | ||
| ExecStart=/bin/echo "pluginactivator disabled for powermanager" |
There was a problem hiding this comment.
The ExecStart has been replaced with a no-op echo command, effectively disabling the PowerManager plugin activation entirely. Every other wpeframework-*.service file in the repository uses ExecStart=/usr/bin/PluginActivator org.rdk.<PluginName> to activate its plugin. This means that at runtime, org.rdk.PowerManager will never be activated, yet the service will still report as active (due to RemainAfterExit=yes) and multiple downstream services that Require it (e.g., wpeframework-system.service, wpeframework-displaysettings.service, wpeframework-telemetry.service, and others) will proceed to start without the PowerManager plugin actually being loaded.
If the intent of this ticket is to remove the service trigger entirely, the correct approach would be to either remove the service file or use ExecStart=/bin/true without a misleading inline comment. If the intent is only temporary (debug/diagnostic), the original PluginActivator line should be restored. Additionally, the inline string "pluginactivator disabled for powermanager" reads as a debug/temporary note rather than production-ready configuration.
| ExecStart=/bin/echo "pluginactivator disabled for powermanager" | |
| ExecStart=/usr/bin/PluginActivator org.rdk.PowerManager |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -1,7 +1,7 @@ | |||
| [Unit] | |||
| Description=WPEFramework HdmiCecSource Initialiser | |||
| Requires=wpeframework.service | |||
There was a problem hiding this comment.
In wpeframework-hdmicecsource.service, dsmgr.service appears in the After= directive but is missing from the Requires= directive. This is inconsistent with all other service files that depend on dsmgr.service (e.g., wpeframework-avinput.service, wpeframework-avoutput.service, wpeframework-hdmicecsink.service, wpeframework-frontpanel.service, etc.), which consistently list dsmgr.service in both Requires= and After=.
Without dsmgr.service in Requires=, systemd will not enforce that dsmgr.service is running before starting HdmiCecSource. The After= ordering dependency alone does not guarantee that dsmgr.service is actually started. dsmgr.service should be added to the Requires= line as well.
| Requires=wpeframework.service | |
| Requires=wpeframework.service dsmgr.service |
No description provided.