Skip to content

RDK-60812: powermanager service trigger removed #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dnnaveen151027 wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

RDK-60812: powermanager service trigger removed #190

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b037bab
powermanager service trigger removed
dnnaveen151027 Mar 2, 2026
6954325
removed the powermanager.service and its dependencies
dnnaveen151027 Mar 3, 2026
254d9b1
displaysettings service file modified
dnnaveen151027 Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions systemd/system/wpeframework-displaysettings.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[Unit]
Description=WPEFramework DisplaySettings Initialiser
Requires=dsmgr.service wpeframework-powermanager.service
After=dsmgr.service wpeframework-powermanager.service
Requires=dsmgr.service pqserver.service wpeframework-hdmicecsink.service wpeframework.service
After=dsmgr.service pqserver.service wpeframework-hdmicecsink.service wpeframework.service
[Service]
Type=oneshot
RemainAfterExit=yes
Expand Down
4 changes: 2 additions & 2 deletions systemd/system/wpeframework-frontpanel.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[Unit]
Description=WPEFramework FrontPanel Initialiser
Requires=wpeframework-powermanager.service dsmgr.service
After=wpeframework-powermanager.service dsmgr.service
Requires=wpeframework.service dsmgr.service
After=wpeframework.service dsmgr.service
ConditionPathExists=/tmp/wpeframeworkstarted
[Service]
Type=oneshot
Expand Down
4 changes: 2 additions & 2 deletions systemd/system/wpeframework-hdcpprofile.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[Unit]
Description=WPEFramework HdcpProfile Initialiser
Requires=wpeframework-powermanager.service dsmgr.service
After=wpeframework-powermanager.service dsmgr.service
Requires=wpeframework.service dsmgr.service
After=wpeframework.service dsmgr.service
ConditionPathExists=/tmp/wpeframeworkstarted
[Service]
Type=oneshot
Expand Down
4 changes: 2 additions & 2 deletions systemd/system/wpeframework-hdmicecsink.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[Unit]
Description=WPEFramework HdmiCecSink Initialiser
Requires=dsmgr.service wpeframework-powermanager.service wpeframework-usersettings.service
After=dsmgr.service wpeframework-powermanager.service wpeframework-usersettings.service
Requires=dsmgr.service wpeframework.service wpeframework-usersettings.service
After=dsmgr.service wpeframework.service wpeframework-usersettings.service
ConditionPathExists=/tmp/wpeframeworkstarted
[Service]
Type=oneshot
Expand Down
2 changes: 1 addition & 1 deletion systemd/system/wpeframework-hdmicecsource.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[Unit]
Description=WPEFramework HdmiCecSource Initialiser
Requires=wpeframework.service
Copy link

Copilot AI Mar 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In wpeframework-hdmicecsource.service, dsmgr.service appears in the After= directive but is missing from the Requires= directive. This is inconsistent with all other service files that depend on dsmgr.service (e.g., wpeframework-avinput.service, wpeframework-avoutput.service, wpeframework-hdmicecsink.service, wpeframework-frontpanel.service, etc.), which consistently list dsmgr.service in both Requires= and After=.

Without dsmgr.service in Requires=, systemd will not enforce that dsmgr.service is running before starting HdmiCecSource. The After= ordering dependency alone does not guarantee that dsmgr.service is actually started. dsmgr.service should be added to the Requires= line as well.

Suggested change
Requires=wpeframework.service
Requires=wpeframework.service dsmgr.service

Copilot uses AI. Check for mistakes.
After=wpeframework-powermanager.service dsmgr.service
After=wpeframework.service dsmgr.service
ConditionPathExists=/tmp/wpeframeworkstarted
[Service]
Type=oneshot
Expand Down
12 changes: 0 additions & 12 deletions systemd/system/wpeframework-powermanager.service
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions systemd/system/wpeframework-system.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[Unit]
Description=WPEFramework System Initialiser
Requires=wpeframework-powermanager.service sysmgr.service mfrmgr.service
After=wpeframework-powermanager.service sysmgr.service mfrmgr.service
Requires=wpeframework.service sysmgr.service mfrmgr.service
After=wpeframework.service sysmgr.service mfrmgr.service
ConditionPathExists=/tmp/wpeframeworkstarted
[Service]
Type=oneshot
Expand Down
4 changes: 2 additions & 2 deletions systemd/system/wpeframework-telemetry.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[Unit]
Description=WPEFramework Telemetry Initialiser
Requires=wpeframework-system.service wpeframework-powermanager.service wpeframework-usersettings.service
After=wpeframework-system.service wpeframework-powermanager.service wpeframework-usersettings.service
Requires=wpeframework-system.service wpeframework.service wpeframework-usersettings.service
After=wpeframework-system.service wpeframework.service wpeframework-usersettings.service
ConditionPathExists=/tmp/wpeframeworkstarted
[Service]
Type=oneshot
Expand Down
4 changes: 2 additions & 2 deletions systemd/system/wpeframework-xcast.service
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
[Unit]
Description=WPEFramework Xcast Initialiser
Requires=wpeframework-powermanager.service
After=wpeframework-powermanager.service
Requires=wpeframework.service
After=wpeframework.service
ConditionPathExists=/tmp/wpeframeworkstarted
[Service]
Type=oneshot
Expand Down