Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: changes are limited to test fixtures and MSW handler setup, with no production logic modifications. Main risk is test brittleness if shared default handlers now return data that some tests implicitly relied on overriding.
Overview
Refactors onboarding-related tests to rely on shared MSW
defaultHandlersinstead of per-test stubs forGET /v1/companies/:companyIdand benefit-offers endpoints.Moves previously in-test fixtures (
companyResponse,benefitOffersResponse,benefitOffersSchema) into common API fixtures by addingmockCompanyResponseinfixtures/companies.tsand introducingfixtures/employments.ts, and wires these intosrc/tests/handlers.ts. Updates invite/onboarding tests to referencemockCompanyResponsewhen overriding credit-risk scenarios, and removes redundant mocks/imports accordingly.Written by Cursor Bugbot for commit 93f7093. This will update automatically on new commits. Configure here.