Skip to content

refactor company tests #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabrielseco wants to merge 2 commits into
base: reduce-bundle-size
Choose a base branch
from
Open

refactor company tests #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03bde10
refactor company tests
gabrielseco Mar 20, 2026
93f7093
refactor mocks
gabrielseco Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions src/common/api/fixtures/companies.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,3 +112,33 @@ export const mockCompanyPricingPlansResponse = {
],
},
};

export const mockCompanyResponse = {
data: {
company: {
id: 'c3c22940-e118-425c-9e31-f2fd4d43c6d8',
name: 'vadance',
status: 'active',
country_code: 'GBR',
updated_at: '2025-05-30T11:34:39',
external_id: null,
created_at: '2024-08-27T22:45:26',
phone_number: '+12403606587',
bank_account_details: null,
tax_number: '7984469',
registration_number: null,
terms_of_service_accepted_at: '2024-08-27T22:45:26Z',
desired_currency: 'USD',
company_owner_email: 'mohit.mahindroo+vadance@remote.com',
company_owner_name: 'Michelll sdassPustomer',
address_details: {
address: '1509 Broderick St',
address_line_2: 'Flat number 123',
city: 'London',
postal_code: 'SW79 8SY',
},
default_legal_entity_credit_risk_status: 'not_started',
company_owner_user_id: 'a8a99466-a159-4bef-a9e1-0cb6939542e1',
},
},
};
594 changes: 594 additions & 0 deletions src/common/api/fixtures/employments.ts
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 0 additions & 4 deletions src/flows/ContractorOnboarding/tests/SaveDraftButton.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ import { render, screen, fireEvent, waitFor } from '@testing-library/react';
import { http, HttpResponse } from 'msw';
import { PropsWithChildren } from 'react';
import { mockBaseResponse } from '@/src/common/api/fixtures/base';
import { companyResponse } from '@/src/flows/Onboarding/tests/fixtures';
import { mockCOROnlyResponse } from '@/src/common/api/fixtures/contractors-subscriptions';

const mockSuccess = vi.fn();
Expand Down Expand Up @@ -103,9 +102,6 @@ describe('SaveDraftButton', () => {
mockRender.mockReset();
queryClient.clear();
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json(companyResponse);
}),
http.get('*/v1/countries/PRT/employment_basic_information*', () => {
return HttpResponse.json(mockBaseResponse);
}),
Expand Down
12 changes: 0 additions & 12 deletions src/flows/Onboarding/tests/OnboardingFlow.basicInformation.v3.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,9 @@ import { OnboardingFlow } from '@/src/flows/Onboarding/OnboardingFlow';
import {
basicInformationSchemaV3Portugal,
basicInformationSchemaV3Korea,
companyResponse,
employmentDefaultResponse,
employmentUpdatedResponse,
benefitOffersSchema,
contractDetailsSchemaV1Portugal,
benefitOffersResponse,
} from '@/src/flows/Onboarding/tests/fixtures';
import {
fillDatePickerByTestId,
Expand Down Expand Up @@ -106,9 +103,6 @@ describe('OnboardingFlow - Basic Information v3', () => {
queryClient.clear();

server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json(companyResponse);
}),
http.get('*/v1/employments/:id', ({ params }) => {
const employmentId = params?.id;
return HttpResponse.json({
Expand All @@ -122,12 +116,6 @@ describe('OnboardingFlow - Basic Information v3', () => {
},
});
}),
http.get('*/v1/employments/*/benefit-offers/schema', () => {
return HttpResponse.json(benefitOffersSchema);
}),
http.get('*/v1/employments/*/benefit-offers', () => {
return HttpResponse.json(benefitOffersResponse);
}),
);
});

Expand Down
13 changes: 1 addition & 12 deletions src/flows/Onboarding/tests/OnboardingFlow.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,14 +12,11 @@ import { OnboardingFlow } from '@/src/flows/Onboarding/OnboardingFlow';
import {
basicInformationSchemaV1Portugal,
contractDetailsSchemaV1Portugal,
benefitOffersSchema,
employmentCreatedResponse,
employmentUpdatedResponse,
benefitOffersResponse,
employmentDefaultResponse,
benefitOffersUpdatedResponse,
inviteResponse,
companyResponse,
conversionFromEURToUSD,
employmentSouthKoreaResponse,
contractDetailsSchemaV1SouthKorea,
Expand Down Expand Up @@ -300,9 +297,6 @@ describe('OnboardingFlow', () => {
queryClient.clear();

server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json(companyResponse);
}),
http.get('*/v1/employments/:id', ({ params }) => {
// Create a response with the actual employment ID from the request
const employmentId = params?.id;
Expand Down Expand Up @@ -331,12 +325,7 @@ describe('OnboardingFlow', () => {
http.get('*/v1/countries/PRT/contract_details*', () => {
return HttpResponse.json(contractDetailsSchemaV1Portugal);
}),
http.get('*/v1/employments/*/benefit-offers/schema', () => {
return HttpResponse.json(benefitOffersSchema);
}),
http.get('*/v1/employments/*/benefit-offers', () => {
return HttpResponse.json(benefitOffersResponse);
}),

http.post('*/v1/employments', () => {
return HttpResponse.json(employmentCreatedResponse);
}),
Expand Down
105 changes: 46 additions & 59 deletions src/flows/Onboarding/tests/OnboardingInvite.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
import { mockCompanyResponse } from '@/src/common/api/fixtures/companies';
import { OnboardingFlow } from '@/src/flows/Onboarding/OnboardingFlow';
import {
basicInformationSchemaV1Portugal,
benefitOffersResponse,
benefitOffersSchema,
companyResponse,
contractDetailsSchemaV1Portugal,
employmentDefaultResponse,
} from '@/src/flows/Onboarding/tests/fixtures';
Expand Down Expand Up @@ -77,10 +75,6 @@ describe('OnboardingInvite', () => {
queryClient.clear();

server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json(companyResponse);
}),

http.get('*/v1/countries/*/employment_basic_information*', () => {
return HttpResponse.json(basicInformationSchemaV1Portugal);
}),
Expand All @@ -93,13 +87,6 @@ describe('OnboardingInvite', () => {
return HttpResponse.json(employmentDefaultResponse);
}),

http.get('*/v1/employments/*/benefit-offers/schema', () => {
return HttpResponse.json(benefitOffersSchema);
}),

http.get('*/v1/employments/*/benefit-offers', () => {
return HttpResponse.json(benefitOffersResponse);
}),
http.post('*/v1/employments/:employmentId/invite', () => {
return HttpResponse.json({
data: { status: 'ok' },
Expand Down Expand Up @@ -132,11 +119,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'deposit_required',
},
},
Expand Down Expand Up @@ -228,11 +215,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'deposit_required',
},
},
Expand Down Expand Up @@ -286,11 +273,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'deposit_required',
},
},
Expand Down Expand Up @@ -330,11 +317,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'deposit_not_required',
},
},
Expand All @@ -354,11 +341,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'deposit_required',
},
},
Expand Down Expand Up @@ -392,11 +379,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'deposit_required',
},
},
Expand Down Expand Up @@ -502,11 +489,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'deposit_required',
},
},
Expand Down Expand Up @@ -545,11 +532,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'deposit_required',
},
},
Expand Down Expand Up @@ -586,11 +573,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'deposit_required',
},
},
Expand Down Expand Up @@ -644,11 +631,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'no_deposit_required',
},
},
Expand Down Expand Up @@ -712,11 +699,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'deposit_not_required',
},
},
Expand Down Expand Up @@ -782,11 +769,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'deposit_not_required',
},
},
Expand All @@ -809,11 +796,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'deposit_required',
},
},
Expand Down Expand Up @@ -847,11 +834,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'deposit_required',
},
},
Expand Down Expand Up @@ -1063,11 +1050,11 @@ describe('OnboardingInvite', () => {
server.use(
http.get('*/v1/companies/:companyId', () => {
return HttpResponse.json({
...companyResponse,
...mockCompanyResponse,
data: {
...companyResponse.data,
...mockCompanyResponse.data,
company: {
...companyResponse.data.company,
...mockCompanyResponse.data.company,
default_legal_entity_credit_risk_status: 'deposit_required',
},
},
Expand Down
Loading