feat: max_hz rate-cap column on ROS2DiagnosticsInfo - #5
Merged
Conversation
The bridge's per-topic throttle reports its effective cap so viewers can annotate the wire rate. Empty column entry means unthrottled. Breaking for DiagnosticsMeta constructors, hence 0.7.0.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
max_hzcolumn to theROS2DiagnosticsInfoarchetype so the bridge can report the effective per-topic throttle cap and viewers can annotate the wire rate. An empty column entry means the topic is unthrottled, mirroring howlatency_msencodes absence, which is also the compatibility contract. Older viewers ignore the unknown component and a newer viewer paired with an older bridge simply renders no cap.Related
REW-200
Breaking change
Adding a field to
DiagnosticsMetais breaking for constructors, hence the bump to 0.7.0.