chore(pitchfork): restore strict schema validation - #3874
Open
risu729 wants to merge 2 commits into
Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRestores strict schema validation in the global Pitchfork configuration by removing the temporary Tombi override that allowed relaxed schema checks. Flow diagram for Pitchfork config validation with restored strict schemaflowchart LR
A[Edit Pitchfork config.toml] --> B[Tombi loads config]
B --> C[Apply schema from schema.json]
C --> D[Check schema strict setting]
D -->|no override - schema strict default| E[Validate groups,namespaces,slugs strictly]
E --> F[Report schema errors on invalid fields]
%% Previous behavior (now removed)
D -->|schema strict false override| G[Relax validation and accept invalid fields]
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#:tombi schema.strict = falsedirective from the global Pitchfork configurationWhy
PR #3867 needed the override because Pitchfork’s published schema did not yet include
groups,namespaces, orslugs. The schema fix from jdx/pitchfork#671 is now published athttps://pitchfork.jdx.dev/schema.json, so Tombi can validate these fields normally.Impact
Schema mistakes in the Pitchfork configuration will once again be reported instead of being accepted under relaxed validation.
Validation
groups,namespaces, andslugshk check --allgit diff --checkSummary by Sourcery
Enhancements: