Skip to content

chore(pitchfork): restore strict schema validation - #3874

Open
risu729 wants to merge 2 commits into
mainfrom
agent/restore-pitchfork-schema-strictness
Open

chore(pitchfork): restore strict schema validation#3874
risu729 wants to merge 2 commits into
mainfrom
agent/restore-pitchfork-schema-strictness

Conversation

@risu729

@risu729 risu729 commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove the temporary #:tombi schema.strict = false directive from the global Pitchfork configuration
  • restore strict schema validation for the newly added namespace and slug registries

Why

PR #3867 needed the override because Pitchfork’s published schema did not yet include groups, namespaces, or slugs. The schema fix from jdx/pitchfork#671 is now published at https://pitchfork.jdx.dev/schema.json, so Tombi can validate these fields normally.

Impact

Schema mistakes in the Pitchfork configuration will once again be reported instead of being accepted under relaxed validation.

Validation

  • confirmed the live Pitchfork schema declares groups, namespaces, and slugs
  • refreshed Tombi’s cached copy of the schema
  • hk check --all
  • git diff --check

Summary by Sourcery

Enhancements:

  • Remove the temporary override that disabled strict schema validation in the global Pitchfork configuration.

@sourcery-ai

sourcery-ai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Restores strict schema validation in the global Pitchfork configuration by removing the temporary Tombi override that allowed relaxed schema checks.

Flow diagram for Pitchfork config validation with restored strict schema

flowchart LR
    A[Edit Pitchfork config.toml] --> B[Tombi loads config]
    B --> C[Apply schema from schema.json]
    C --> D[Check schema strict setting]
    D -->|no override - schema strict default| E[Validate groups,namespaces,slugs strictly]
    E --> F[Report schema errors on invalid fields]

    %% Previous behavior (now removed)
    D -->|schema strict false override| G[Relax validation and accept invalid fields]
Loading

File-Level Changes

Change Details Files
Re-enable strict schema validation for the Pitchfork configuration
  • Remove the temporary Tombi directive that set schema.strict = false so configuration is validated strictly against the live Pitchfork schema
  • Keep the schema URL pointing at the now-updated Pitchfork schema that includes groups, namespaces, and slugs
wsl/home/.config/pitchfork/config.toml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant