Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughAdds two release automation scripts (tag-main-release.sh, verify-registry-install.js), moves registry-install verification out of the GitHub Actions workflow into the new verifier script, and bumps the package version from 6.1.2 to 6.1.3 across package.json and source constants. Changes
Sequence Diagram(s)mermaid Estimated code review effort🎯 3 (Moderate) | ⏱️ ~28 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/tag-main-release.sh`:
- Around line 30-31: PACKAGE_VERSION is read before the script fast-forwards
local main, which can cause a tag/version mismatch; after the sections that
update or fast-forward main (the blocks that modify local main referenced in the
comment and the later similar blocks around lines 54-61 and 93-96), re-read
package.json and reassign PACKAGE_VERSION (and reset VERSION if used) so the tag
uses the up-to-date version; update usages of PACKAGE_VERSION/VERSION to use the
refreshed variables before creating the tag.
In `@scripts/verify-registry-install.js`:
- Around line 86-93: The runCommand function currently calls execFileSync
without a timeout which can hang indefinitely; modify runCommand (the function
named runCommand that uses execFileSync) to pass a timeout option (e.g.,
timeout: some reasonable ms like 30_000) into the execFileSync options and
surface a clear error when the timeout elapses so the existing retry loop can
continue; ensure the new option preserves cwd, env, encoding and stdio behavior
and that any timeout-related exception is handled/propagated by the caller so
retries proceed instead of blocking forever.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f3eb0d2f-bdb5-47a9-a77c-8e55f02e76c4
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (6)
.github/workflows/release.ymlRELEASING.mdpackage.jsonscripts/tag-main-release.shscripts/verify-registry-install.jssrc/lib/constants.ts
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
scripts/tag-main-release.sh (1)
33-50: Reject unknown flags explicitly.Unrecognized
-prefixed args are currently treated asversion. Consider failing early with an “unknown option” error for clearer CLI behavior.💡 Proposed refinement
*) + if [[ "$arg" == -* ]]; then + echo "Unknown option: $arg" + usage + exit 1 + fi if [[ -n "$VERSION" ]]; then echo "Only one version argument is allowed." usage exit 1 fi🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@scripts/tag-main-release.sh` around lines 33 - 50, The CLI currently treats unknown hyphen-prefixed args as a VERSION; update the argument parsing in the for loop to explicitly reject unrecognized options by adding a case branch (e.g., '-*') that prints an "Unknown option" error, calls usage, and exits with non-zero status; keep the existing handlers for -h|--help and --dry-run (which sets DRY_RUN) and the VERSION assignment logic unchanged so only valid flags are accepted and everything else is validated as the positional VERSION.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@scripts/tag-main-release.sh`:
- Around line 64-74: The script constructs TAG_NAME="v$VERSION" before ensuring
VERSION is set, causing checks to look for tag "v" when VERSION is empty; move
or add the VERSION resolution (the logic that reads the [version] argument or
falls back to package.json) to execute before computing TAG_NAME and running the
git tag-existence checks, and then use the resolved VERSION when setting
TAG_NAME; update references to TAG_NAME in the existing checks (the if blocks
that call git rev-parse and git ls-remote) so they run only after VERSION is
resolved.
---
Nitpick comments:
In `@scripts/tag-main-release.sh`:
- Around line 33-50: The CLI currently treats unknown hyphen-prefixed args as a
VERSION; update the argument parsing in the for loop to explicitly reject
unrecognized options by adding a case branch (e.g., '-*') that prints an
"Unknown option" error, calls usage, and exits with non-zero status; keep the
existing handlers for -h|--help and --dry-run (which sets DRY_RUN) and the
VERSION assignment logic unchanged so only valid flags are accepted and
everything else is validated as the positional VERSION.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: a50ab832-bd42-48f1-8c9b-9189b3d31ced
📒 Files selected for processing (2)
scripts/tag-main-release.shscripts/verify-registry-install.js
🚧 Files skipped from review as they are similar to previous changes (1)
- scripts/verify-registry-install.js
1 participant
Summary by CodeRabbit
Chores
New Features
Workflow