Closed
Conversation
This can lead to corruption of the owning process’ static variables.
…_address. Fixes function level static variables.
Member
|
Thanks! Moved to root-project/root#745. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thread_local is part of the standard, so somewhat necessary to be compliant.
Windows uses thread local storage for its implementation of C++ static semantics.
Currently cling will not complain about thread_local, but due to the way it is implemented on OS X and Linux will likely crash from any extensive usage. By using emulated TLS the thread local data will be dynamically generated so that using them will not overwrite the owning process's thread local data stored in a section of the binary.