cling PR 169 by Axel-Naumann · Pull Request #745 · root-project/root

Axel-Naumann · 2017-07-06T08:03:46Z

… to corruption of the owning process’ static variables.

…_address. Fixes function level static variables.

phsft-bot · 2017-07-06T08:03:57Z

Starting build on gcc49/centos7, native/mac1012, gcc49/slc6, gcc62/slc6, native/ubuntu14 with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

bellenot · 2017-07-06T08:57:43Z

According to this Appveyor build, this doesn't look to fix any test (not even CodeGeneration/Statics.C):

  Failing Tests (11):
      Cling :: CodeGeneration/Statics.C
      Cling :: CodeGeneration/Symbols.C
      Cling :: CodeGeneration/TLSVars.C
      Cling :: CodeUnloading/PCH/VTablesClingPCH.C
      Cling :: Driver/Gnu.C
      Cling :: Lookup/data.C
      Cling :: Lookup/func.C
      Cling :: NullDeref/MethodCalls.C
      Cling :: Prompt/OutputRedirect.C
      Cling :: Prompt/ValuePrinter/Regression.C
      Cling :: Utils/Transform.C
  
    Expected Passes    : 109
    Expected Failures  : 12
    Unsupported Tests  : 1
    Unexpected Failures: 11

marsupial · 2017-07-06T14:19:15Z

Appveyor is also saying it is generating a warning which it should not be doing.
What does it do/say when applied locally?
I just tried locally with ELF & Release and it passed...

marsupial · 2017-07-06T14:45:41Z

And prior Appveyor builds show CodeGeneration/Statics.C was just crashing, so it does fix something.

bellenot · 2017-07-06T14:48:08Z

Sorry @marsupial, I overlooked at the log, I just saw the same tests failing before and after...

bellenot · 2017-07-06T15:06:54Z

BTW, the indentation in this PR is not consistent (sometimes two spaces, sometimes four...)

marsupial · 2017-07-06T16:42:52Z

I assume you are talking about EmuTLS.cpp?
The original is from compiler-rt, which poached it from gcc.
Keeping the indentation at 4 makes it easier to re-integrate when updates occur.

BTW, could you look at root-project/cling#174

bellenot · 2017-07-07T07:13:12Z

OK, I understand, it makes sense, thanks for the explanation. And see my comment on the PR-174

vgvassilev · 2017-07-13T14:07:42Z

Does 177 supersede this one? Shall we close it?

marsupial · 2017-07-13T14:13:49Z

This is a subset, but crashes OS X & linux too (see test/CodeGeneration/TLSVars.C) so might be worth dealing with on its own as it can easily be taken out of 177.

177 is huge and contains everything necessary for Windows to pass.
(As far as i know https://ci.appveyor.com/project/bellenot/cling/build/1.0.312)

vgvassilev · 2017-08-15T10:42:43Z

@phsft-bot build!

phsft-bot · 2017-08-15T10:42:58Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, ubuntu14/native with flags -Dvc=OFF -Dimt=ON -Dccache=ON
How to customize builds

vgvassilev · 2017-11-07T17:09:20Z

@phsft-bot build with flags -Dclingtest=On

phsft-bot · 2017-11-07T17:09:28Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dclingtest=On
How to customize builds

phsft-bot · 2017-11-07T17:37:32Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

projectroot.interpreter.clingtest_check_cling

phsft-bot · 2017-11-07T17:40:05Z

Build failed on slc6/gcc49.
See console output.

Failing tests:

projectroot.interpreter.clingtest_check_cling

phsft-bot · 2017-11-07T17:56:45Z

Build failed on ubuntu14/native.
See console output.

Failing tests:

projectroot.interpreter.clingtest_check_cling

phsft-bot · 2017-11-07T18:01:30Z

Build failed on mac1012/native.
See console output.

Warnings:

/cvmfs/sft.cern.ch/lcg/releases/R/3.2.5-c8cca/x86_64-mac1012-clang81-opt/lib/R/include/R.h:40:10: warning: non-portable path to file '<RConfig.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
/cvmfs/sft.cern.ch/lcg/releases/R/3.2.5-c8cca/x86_64-mac1012-clang81-opt/lib/R/include/R_ext/RS.h:29:10: warning: non-portable path to file '<RConfig.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
/cvmfs/sft.cern.ch/lcg/releases/R/3.2.5-c8cca/x86_64-mac1012-clang81-opt/lib/R/include/Rinternals.h:60:11: warning: non-portable path to file '<RConfig.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
/cvmfs/sft.cern.ch/lcg/releases/R/3.2.5-c8cca/x86_64-mac1012-clang81-opt/lib/R/library/Rcpp/include/Rcpp/r/headers.h:57:10: warning: non-portable path to file '<RVersion.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
/cvmfs/sft.cern.ch/lcg/releases/R/3.2.5-c8cca/x86_64-mac1012-clang81-opt/lib/R/include/R_ext/Visibility.h:29:10: warning: non-portable path to file '<RConfig.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
/cvmfs/sft.cern.ch/lcg/releases/R/3.2.5-c8cca/x86_64-mac1012-clang81-opt/lib/R/include/R.h:40:10: warning: non-portable path to file '<RConfig.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
/cvmfs/sft.cern.ch/lcg/releases/R/3.2.5-c8cca/x86_64-mac1012-clang81-opt/lib/R/include/R_ext/RS.h:29:10: warning: non-portable path to file '<RConfig.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
/cvmfs/sft.cern.ch/lcg/releases/R/3.2.5-c8cca/x86_64-mac1012-clang81-opt/lib/R/include/Rinternals.h:60:11: warning: non-portable path to file '<RConfig.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
/cvmfs/sft.cern.ch/lcg/releases/R/3.2.5-c8cca/x86_64-mac1012-clang81-opt/lib/R/library/Rcpp/include/Rcpp/r/headers.h:57:10: warning: non-portable path to file '<RVersion.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]
/cvmfs/sft.cern.ch/lcg/releases/R/3.2.5-c8cca/x86_64-mac1012-clang81-opt/lib/R/include/R_ext/Visibility.h:29:10: warning: non-portable path to file '<RConfig.h>'; specified path differs in case from file name on disk [-Wnonportable-include-path]

And 10 more

Failing tests:

projectroot.interpreter.clingtest_check_cling

phsft-bot · 2017-11-07T18:12:52Z

Build failed on centos7/gcc49.
See console output.

Failing tests:

projectroot.interpreter.clingtest_check_cling

phsft-bot · 2017-11-07T18:16:55Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

projectroot.interpreter.clingtest_check_cling

phsft-bot · 2017-11-07T18:17:08Z

Build failed on ubuntu14/native.
See console output.

Failing tests:

projectroot.interpreter.clingtest_check_cling

Axel-Naumann · 2017-11-07T19:20:03Z

@phsft-bot build with flags -Dclingtest=On now that I've fixed the cling tests.

phsft-bot · 2017-11-07T19:20:10Z

Starting build on centos7/gcc49, mac1012/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu14/native, ubuntu14/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dclingtest=On
How to customize builds

phsft-bot · 2017-11-07T19:20:59Z

Build failed on windows10/vc15.
See console output.

etejedor · 2018-02-20T13:00:07Z

@bellenot is it understood why the windows build fails here? It this WIP?

oshadura · 2018-03-21T10:18:02Z

@phsft-bot build with flags -Dclingtest=On

phsft-bot · 2018-03-21T10:18:27Z

Starting build on centos7/gcc49, mac1013/native, slc6/gcc49, slc6/gcc62, slc6/gcc62, ubuntu16/native, ubuntu16/native, windows10/vc15 with flags -Dvc=OFF -Dimt=ON -Dccache=ON -Dclingtest=On
How to customize builds

phsft-bot · 2018-03-21T11:13:09Z

Build failed on slc6/gcc49.
See console output.

Failing tests:

projectroot.interpreter.clingtest_check_cling

phsft-bot · 2018-03-21T11:19:27Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

projectroot.interpreter.clingtest_check_cling

phsft-bot · 2018-03-21T11:20:11Z

Build failed on centos7/gcc49.
See console output.

Failing tests:

projectroot.interpreter.clingtest_check_cling

phsft-bot · 2018-03-21T11:33:40Z

Build failed on slc6/gcc62.
See console output.

Failing tests:

projectroot.interpreter.clingtest_check_cling

phsft-bot · 2018-03-21T12:04:50Z

Build failed on ubuntu16/native.
See console output.

Failing tests:

projectroot.interpreter.clingtest_check_cling

phsft-bot · 2018-03-21T12:15:13Z

Build failed on mac1013/native.
See console output.

Failing tests:

projectroot.interpreter.clingtest_check_cling

phsft-bot · 2018-03-21T12:58:32Z

Build failed on ubuntu16/native.
See console output.

Failing tests:

etejedor · 2018-04-26T08:28:44Z

@bellenot do we need to rescue this PR or it is obsolete?

etejedor · 2018-07-26T11:01:48Z

@bellenot do we need to rescue this PR or it is obsolete?

lmoneta · 2019-01-29T15:40:51Z

@bellenot do we declare it obsolete ?

bellenot · 2019-01-29T16:34:41Z

@moneta I would keep it for the time being (it is not clear what has been taken and what not...)

marsupial added 5 commits July 6, 2017 10:03

Windows: Don’t export _Init_thread_epoch to _tls_index. This can lead…

4d5ffcd

… to corruption of the owning process’ static variables.

Add EmuTLS.cpp.

525d0d7

Implement __emutls_get_address on Windows.

6f2bd2a

Enable emulated TLS and add test.

eff7edf

Windows: Return current thread’s _Init_thread_epoch from __emutls_get…

a96d2b3

…_address. Fixes function level static variables.

Axel-Naumann mentioned this pull request Jul 6, 2017

Support thread_local data. root-project/cling#169

Closed

Axel-Naumann assigned bellenot Jul 6, 2017

bellenot mentioned this pull request Jul 10, 2017

Windows CI: Test multiple fixes against CERN/master. root-project/cling#177

Closed

eguiraud added the stale label Mar 10, 2020

bellenot closed this Mar 10, 2020

Conversation

Axel-Naumann commented Jul 6, 2017

Uh oh!

phsft-bot commented Jul 6, 2017

Uh oh!

bellenot commented Jul 6, 2017

Uh oh!

marsupial commented Jul 6, 2017

Uh oh!

marsupial commented Jul 6, 2017

Uh oh!

bellenot commented Jul 6, 2017

Uh oh!

bellenot commented Jul 6, 2017

Uh oh!

marsupial commented Jul 6, 2017

Uh oh!

bellenot commented Jul 7, 2017

Uh oh!

vgvassilev commented Jul 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marsupial commented Jul 13, 2017

Uh oh!

vgvassilev commented Aug 15, 2017

Uh oh!

phsft-bot commented Aug 15, 2017

Uh oh!

vgvassilev commented Nov 7, 2017

Uh oh!

phsft-bot commented Nov 7, 2017

Uh oh!

phsft-bot commented Nov 7, 2017

Failing tests:

Uh oh!

phsft-bot commented Nov 7, 2017

Failing tests:

Uh oh!

phsft-bot commented Nov 7, 2017

Failing tests:

Uh oh!

phsft-bot commented Nov 7, 2017

Warnings:

Failing tests:

Uh oh!

phsft-bot commented Nov 7, 2017

Failing tests:

Uh oh!

phsft-bot commented Nov 7, 2017

Failing tests:

Uh oh!

phsft-bot commented Nov 7, 2017

Failing tests:

Uh oh!

Axel-Naumann commented Nov 7, 2017

Uh oh!

phsft-bot commented Nov 7, 2017

Uh oh!

phsft-bot commented Nov 7, 2017

Uh oh!

etejedor commented Feb 20, 2018

Uh oh!

oshadura commented Mar 21, 2018

Uh oh!

phsft-bot commented Mar 21, 2018

Uh oh!

phsft-bot commented Mar 21, 2018

Failing tests:

Uh oh!

phsft-bot commented Mar 21, 2018

Failing tests:

Uh oh!

phsft-bot commented Mar 21, 2018

Failing tests:

Uh oh!

phsft-bot commented Mar 21, 2018

Failing tests:

Uh oh!

phsft-bot commented Mar 21, 2018

Failing tests:

vgvassilev commented Jul 13, 2017 •

edited

Loading