Skip to content

Windows: Fix declaration for C99 and re-enable Gnu.C test.#174

Closed
marsupial wants to merge 2 commits intoroot-project:masterfrom
marsupial:PR/3
Closed

Windows: Fix declaration for C99 and re-enable Gnu.C test.#174
marsupial wants to merge 2 commits intoroot-project:masterfrom
marsupial:PR/3

Conversation

@marsupial
Copy link
Copy Markdown
Contributor

The test was failing for a reason that likely shouldn't be ignored.

This reverts commit 5947e13.

@bellenot
Copy link
Copy Markdown
Member

bellenot commented Jul 7, 2017

And it's still failing...

@marsupial
Copy link
Copy Markdown
Contributor Author

Hopefully no longer.

@bellenot
Copy link
Copy Markdown
Member

bellenot commented Jul 7, 2017

Remove C++11 test which Visual Studio cannot handle.

And what about the other platforms?

@marsupial
Copy link
Copy Markdown
Contributor Author

The test is for GNU keywords, having -std=gnu++14 -std=gnu++1z is enough as they test the same mechanism.
-std=gnu++11 really adds nothing but failure for Windows, and fixing for that would mean you're just testing that C++11 cannot run on Windows

If someone feels it is really necessary, then it would probably be best to have a directory devoted to C++11 tests that are not activated on Windows rather than allowing failure all over.

@bellenot
Copy link
Copy Markdown
Member

bellenot commented Jul 7, 2017

OK, thanks for the explanation @marsupial. If @vgvassilev confirm (and agrees), and if it fixes the test, then it is would be fine with me

@marsupial
Copy link
Copy Markdown
Contributor Author

Updated again to work-around the Windows issue without dropping it entirely.

@vgvassilev
Copy link
Copy Markdown
Member

Looks good to me.

@pcanal
Copy link
Copy Markdown
Member

pcanal commented Aug 16, 2017

@phsft-bot build

ferdymercury added a commit to ferdymercury/root that referenced this pull request Oct 15, 2024
The test was failing for a reason that likely shouldn't be ignored.
This reverts commit 5947e13.
This is a rebased version of root-project/cling#174 by marsupial
@ferdymercury
Copy link
Copy Markdown
Contributor

Moved to root-project/root#16694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants