[ci] build with clingtest flag active if interpreter folder was touched#16917
[ci] build with clingtest flag active if interpreter folder was touched#16917ferdymercury wants to merge 3 commits intoroot-project:masterfrom
Conversation
dpiparo
left a comment
There was a problem hiding this comment.
This PR is a great attempt to introduce a useful new feature. It seems some information is still needed before starting to test it thoroughly.
|
These changes are too advanced for me. Maybe @mcbarton could take a look... |
Test Results 18 files 18 suites 4d 5h 33m 48s ⏱️ For more details on these failures, see this check. Results for commit 3db45e0. ♻️ This comment has been updated with latest results. |
071e211 to
347b083
Compare
|
It's working now. Should we also:
|
40b9857 to
6d5e3a8
Compare
hahnjo
left a comment
There was a problem hiding this comment.
This looks really (too) complicated and IMHO is not what we actually want:
check-clingdoesn't seem to work in-tree on Windows.- On Apple Silicon, we (still) cannot catch exceptions from interpreted code and therefore many (all?)
NullDereftests fail. We probably want to start with an x86 machine. - For Linux, as I predicted in #6957 (comment), exposing the LLVM symbols from
libClinginterferes with other libraries, in this case TensorFlow (but I think we have seen problems with Mesa in the past as well). roottest-root-meta-countIncludePathschecks the number of include paths, which is larger withclingtest=ONto make the tests pass.
In general, as was discussed before, we still want to run all PR builds because this is what matters for ROOT's functionality. On top of this, we want extra builds with clingtest that only execute check-cling. This can be accomplished much easier with a separate workflow that triggers on pull_request with paths.
Changed.
This should be fixed in my opinion in the CMakeLists using an
I hope someone can implement that variant soon ;) and I will close this PR then. |
Fixes root-project#15230 [ci] move clingtest to a non-apple-silicon machine hahnjo: On Apple Silicon, we (still) cannot catch exceptions from interpreted code and therefore many (all?) NullDeref tests fail.
669d394 to
3db45e0
Compare
|
Closing in favour of #18127 |
This Pull request:
Changes or fixes:
Fixes #15230
Fixes #6957
Sibling PR in root-project/roottest#1232
Checklist: