[CI] Run cling tests on CI#18127
Draft
devajithvs wants to merge 5 commits intoroot-project:masterfrom
Draft
Conversation
Collaborator
|
Thanks for this! Should I close then #16917 ? The main difference was that the special build was only running if 'cling' was touched. |
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit b1e3a39. ♻️ This comment has been updated with latest results. |
Contributor
Author
Yes, thanks @ferdymercury. I was just experimenting with the idea of having a separate instance with just cling-tests turned on as we can't have cling-tests run with other tests due to exposed LLVM symbols. |
2 tasks
5c84a8f to
e8723d6
Compare
| pull_request: | ||
| paths: | ||
| - 'interpreter/cling/**' | ||
| - '.github/workflows/cling-check.yml' |
Collaborator
There was a problem hiding this comment.
Suggested change
| - '.github/workflows/cling-check.yml' | |
| - '.github/workflows/cling-test.yml' |
?
2 tasks
46f9f57 to
88b297b
Compare
d100dda to
07e7fae
Compare
07e7fae to
7305e2d
Compare
When cling is built with C++17, the implementation in ValuePrinter.cpp is not compiled. When cling is later used with -std=c++20, we don't have the implementation to print `source_location`
Fix the following assertion failure in cling: ``` [cling]$ #include <filesystem> Transaction.cpp:180: void cling::Transaction::forceAppend(DelayCallInfo): Assertion `oldDCI != DCI && "Duplicates?!"' failed. ```
7305e2d to
3a62cc8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
Checklist:
Fixes #15230
Fixes #6957