Skip to content

[CI] Run cling tests on CI#18127

Draft
devajithvs wants to merge 5 commits intoroot-project:masterfrom
devajithvs:cling-test
Draft

[CI] Run cling tests on CI#18127
devajithvs wants to merge 5 commits intoroot-project:masterfrom
devajithvs:cling-test

Conversation

@devajithvs
Copy link
Copy Markdown
Contributor

@devajithvs devajithvs commented Mar 25, 2025

This Pull request:

Changes or fixes:

Checklist:

  • tested changes locally
  • updated the docs (if necessary)

Fixes #15230
Fixes #6957

@devajithvs devajithvs requested a review from dpiparo as a code owner March 25, 2025 11:02
@devajithvs devajithvs marked this pull request as draft March 25, 2025 11:02
@devajithvs devajithvs self-assigned this Mar 25, 2025
@ferdymercury
Copy link
Copy Markdown
Collaborator

Thanks for this! Should I close then #16917 ? The main difference was that the special build was only running if 'cling' was touched.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 25, 2025

Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit b1e3a39.

♻️ This comment has been updated with latest results.

Comment thread .github/workflows/root-ci-config/build_root.py Outdated
@devajithvs
Copy link
Copy Markdown
Contributor Author

Thanks for this! Should I close then #16917 ? The main difference was that the special build was only running if 'cling' was touched.

Yes, thanks @ferdymercury. I was just experimenting with the idea of having a separate instance with just cling-tests turned on as we can't have cling-tests run with other tests due to exposed LLVM symbols.

Comment thread .github/workflows/cling-test.yml Outdated
pull_request:
paths:
- 'interpreter/cling/**'
- '.github/workflows/cling-check.yml'
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- '.github/workflows/cling-check.yml'
- '.github/workflows/cling-test.yml'

?

When cling is built with C++17, the implementation in ValuePrinter.cpp
is not compiled. When cling is later used with -std=c++20, we don't have
the implementation to print `source_location`
Fix the following assertion failure in cling:

```
[cling]$ #include <filesystem>
Transaction.cpp:180: void cling::Transaction::forceAppend(DelayCallInfo):
Assertion `oldDCI != DCI && "Duplicates?!"' failed.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] clingtest=ON when cling touched Enable cling-test for nightly, PR builds

2 participants