[civetweb] download instead of bundle, bump from 1.15 to 1.16, and define proper CMake target#21947
[civetweb] download instead of bundle, bump from 1.15 to 1.16, and define proper CMake target#21947ferdymercury wants to merge 42 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 13h 0m 11s ⏱️ For more details on these failures, see this check. Results for commit be0cde1. ♻️ This comment has been updated with latest results. |
| ${FASTCGI_LIBRARY} | ||
| ${CMAKE_DL_LIBS} | ||
| civetweb::civetweb | ||
| DEPENDENCIES |
There was a problem hiding this comment.
TO-DO: discuss if builtin_civetweb=OFF should be discouraged, by emitting a warning or better describing ROotBuildOptions text.
See discussion root-project/root-ci-images#110 (comment)
ferdymercury
added
the
skip code analysis
|
@linev for Fedora we'd need root-project/root-ci-images#111 |
| endif() | ||
| endif() | ||
| if (NOT builtin_civetweb) | ||
| target_compile_definitions(civetweb::civetweb INTERFACE _EXTERNAL_CIVETWEB) # temporary hack for: with external civetweb one gets failure R__memcompress |
There was a problem hiding this comment.
TO-DO investigate
|
@linev do you have a Mac where you could try out this PR ? It's the only platform failing, with error:
Could you run |
Compilation with builtin_openssl probably just worked fine because it picked system-wide openssl headers rather than the builtin ones. Found out while investigating failures in root-project#21947
|
Finally! Compilation failures on Mac solved, now builds on all platforms. |
and copy-paste additional variables from xrootd to civetweb
2 participants
No description provided.