[openssl] builtin: destination of include files was not correct#22026
Open
ferdymercury wants to merge 1 commit intoroot-project:masterfrom
Open
[openssl] builtin: destination of include files was not correct#22026ferdymercury wants to merge 1 commit intoroot-project:masterfrom
ferdymercury wants to merge 1 commit intoroot-project:masterfrom
Conversation
Compilation with builtin_openssl probably just worked fine because it picked system-wide openssl headers rather than the builtin ones. Found out while investigating failures in root-project#21947
Test Results 22 files 22 suites 3d 8h 51m 53s ⏱️ For more details on these failures, see this check. Results for commit e3e1e6d. ♻️ This comment has been updated with latest results. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compilation on mac of XRootd and/or civetweb with builtin_openssl probably just worked fine because it picked system-wide openssl headers rather than the builtin ones.
Found out while investigating failures in #21947 of the type
openssl/bn.hnot found even if it was correctly doing `include_directories("/Users/sftnight/ROOT-CI/build/builtins/openssl/OPENSSL-prefix/include")See https://github.com/root-project/root/actions/runs/24824049926/job/72655476462
Note that Makefile.in of the openssl repository has extra logic depending on if
openssldiris passed or not, and modifies the destination suffixes accordingly.