Release ownership of entities after spinning cancelled (backport #2556)#2580
Merged
fujitatomoya merged 2 commits intojazzyfrom Jul 18, 2024
Merged
Release ownership of entities after spinning cancelled (backport #2556)#2580fujitatomoya merged 2 commits intojazzyfrom
fujitatomoya merged 2 commits intojazzyfrom
Conversation
* Release ownership of entities after spinning cancelled Signed-off-by: Barry Xu <barry.xu@sony.com> * Move release action to every exit point in different spin functions Signed-off-by: Barry Xu <barry.xu@sony.com> * Move wait_result_.reset() before setting spinning to false Signed-off-by: Barry Xu <barry.xu@sony.com> * Update test code Signed-off-by: Barry Xu <barry.xu@sony.com> * Move test code to test_executors.cpp Signed-off-by: Barry Xu <barry.xu@sony.com> --------- Signed-off-by: Barry Xu <barry.xu@sony.com> (cherry picked from commit 069a001) # Conflicts: # rclcpp/test/rclcpp/executors/test_executors.cpp
Contributor
Author
|
Cherry-pick of 069a001 has failed: To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
@Barry-Xu-2018 i think this fix should be backported to jazzy, but git found conflict. could you resolve that?
CC: @alsora
Collaborator
Okay. I will fix it. |
Signed-off-by: Barry Xu <barry.xu@sony.com>
Contributor
alsora
approved these changes
Jul 10, 2024
Member
|
Looks like the Linux runner filled up: |
Collaborator
Collaborator
|
The reason for the test failure for Linux-aarch64 is |
fujitatomoya
approved these changes
Jul 18, 2024
Collaborator
fujitatomoya
left a comment
There was a problem hiding this comment.
@Barry-Xu-2018 thanks for resolving the conflicts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This issue was found in ros2/rmw_fastrtps#761.
In code of MoveIt, it used static executor. When the static executor is destructed (The executor is in a cancel state.), and it's time to free up the ownership of entity resources, Fast DDS resources have already been released.
After spinning is cancelled, the Executor should release ownership of entities at once.
This is an automatic backport of pull request #2556 done by Mergify.