Add context manager for adding DLL directories to the search path#2
Merged
jacobperron merged 3 commits intomasterfrom May 18, 2020
Merged
Add context manager for adding DLL directories to the search path#2jacobperron merged 3 commits intomasterfrom
jacobperron merged 3 commits intomasterfrom
Conversation
The list of DLL directories is read from the specified environment variable and added to the Windows search path for DLLs. This only applies to Python 3.8+. Any values in the environment variable that are not directories are ignored. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
This was referenced May 16, 2020
dirk-thomas
reviewed
May 16, 2020
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
approved these changes
May 16, 2020
nuclearsandwich
approved these changes
May 18, 2020
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list of DLL directories is read from the specified environment variable and added
to the Windows search path for DLLs. This only applies to Python 3.8+.
Any values in the environment variable that are not directories are ignored.
I've updated ros2/rclpy#558 to demonstrate how this is used. After a review, I'll update other Python packages that need a similar patch.