build(deps): bundle grpc 1.83.2 and opa 1.20.1 - #836
Conversation
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.83.1 to 1.83.2. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.83.1...v1.83.2) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.83.2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Auto-tidied by dependabot-tidy workflow to keep cmd/* go.sum files in sync with authlib after a Dependabot bump. Signed-off-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [github.com/open-policy-agent/opa](https://github.com/open-policy-agent/opa) from 1.19.1 to 1.20.1. - [Release notes](https://github.com/open-policy-agent/opa/releases) - [Changelog](https://github.com/open-policy-agent/opa/blob/main/CHANGELOG.md) - [Commits](open-policy-agent/opa@v1.19.1...v1.20.1) --- updated-dependencies: - dependency-name: github.com/open-policy-agent/opa dependency-version: 1.20.1 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Re-tidies the cmd/* modules after bundling the grpc and opa bumps onto one branch. The dependabot-tidy workflow cannot do this here: it is gated on `if: github.actor == 'dependabot[bot]'`, and this branch is human-authored. Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Hai Huang <huang195@gmail.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: ⛔ Files ignored due to path filters (6)
📒 Files selected for processing (6)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request updates dependency versions in six Go modules. It upgrades OPA, gRPC, genproto, klauspost/compress, and Prometheus dependencies without changing exported declarations or application code. ChangesGo dependency refresh
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This change updates bundled gRPC, OPA, and related Go dependency versions without altering application behavior; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The pull request upgrades gRPC from 1.83.1 to 1.83.2 and OPA from 1.19.1 to 1.20.1 in the affected Go modules. The additional genproto and indirect dependency updates support module resolution and tidying. Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (6 skipped: 6 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 golangci-lint (2.13.2)level=error msg="Running error: context loading failed: no go files to analyze: running Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mrsabath
left a comment
There was a problem hiding this comment.
Summary
Clean dependency-bump bundle. Merges two forward Dependabot bumps into a single CI cycle:
google.golang.org/grpc1.83.1 → 1.83.2 (#831)github.com/open-policy-agent/opa1.19.1 → 1.20.1 (#832)
I verified the substance rather than the narrative:
- Pure version bumps. Diffed the module paths on the
+vs-side across all six modules' go.mod — every changed require line is a version transition; no module path is added or dropped relative tomain. Confirms the "no dependency added or removed" claim. - Conflict resolution is sound. grpc lands at 1.83.2 with the newer
genproto/googleapis/rpc(v0.0.0-20260720211330-0afa2a65878a) — the union of the two branches, and the lockfiles agree after tidy. tidyskipping is expected, not a gap:dependabot-tidy.ymlis gated ongithub.actor == 'dependabot[bot]', so it can't run on a human branch. The final commits reproduce that loop by hand.
All CI green — the three Go CI jobs (authlib / authbridge-envoy / authbridge-proxy), Dependency Review (supply-chain gate), CodeQL, Trivy, and CodeRabbit. 4 commits, all DCO-signed.
Bundling to save a CI cycle is 一举两得 (one move, two gains). LGTM.
Areas reviewed: Go dependencies (go.mod/go.sum), CI status, supply-chain (Dependency Review)
Commits: 4, all signed-off (DCO passes)
CI status: passing (tidy skipped by design)
Summary
Bundles two low-risk Dependabot bumps into one PR so they cost a single CI cycle instead of two, plus a rebase:
google.golang.org/grpc1.83.1 → 1.83.2 (chore: bump google.golang.org/grpc from 1.83.1 to 1.83.2 in /authbridge/authlib #831)github.com/open-policy-agent/opa1.19.1 → 1.20.1 (chore: bump github.com/open-policy-agent/opa from 1.19.1 to 1.20.1 in /authbridge/authlib #832)Both PRs rewrite the same six
go.mod/go.sumfiles, so merging them separately means the second one force-rebases and re-runs CI from scratch. Bundling avoids that.One conflict worth noting
The two branches disagreed on a third dependency. #832 also carried
google.golang.org/genproto/googleapis/rpcforward tov0.0.0-20260720211330-0afa2a65878awhile pinning grpc at 1.83.1; #831 kept the older genproto revision alongside grpc 1.83.2. Resolved as the union — grpc 1.83.2 with the newer genproto — then re-tidied so the lockfiles agree.Tidy had to be done by hand
.github/workflows/dependabot-tidy.ymlis gated onif: github.actor == 'dependabot[bot]', so it will not run on this human-authored branch. The final commit reproduces its exact loop locally (GOWORK=off,go mod tidyin everyauthbridge/**/go.modexcludingdemos/).Verification
Run locally against Go 1.26.5 (the version
authbridge/authlib/go.modpins, which is whatsetup-goresolves in CI viago-version-file):authlibcmd/abctlcmd/authbridge-envoycmd/authbridge-praxiscmd/authbridge-proxystorage/rediscmd/authbridge-cpexcmd/authbridge-cpexhas no packages without-tags cpex(main.gois behind//go:build cpex), so./...matches nothing there — pre-existing, and that module is not one of the three Go CI jobs. With-tags cpexit compiles but cannot link locally for want oflibcpex_ffifrom the CPEX Rust build, which is an environment prerequisite unrelated to these bumps.The diff is purely version bumps: 102 insertions, 102 deletions across 12 files, with no dependency added or removed relative to
main.Closes #831
Closes #832
Assisted-By: Claude Code
Summary by CodeRabbit