chore(deps): bump the grpc-protobuf group in /gen/go with 2 updates - #210
Closed
dependabot[bot] wants to merge 1 commit into
Closed
chore(deps): bump the grpc-protobuf group in /gen/go with 2 updates#210dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps the grpc-protobuf group in /gen/go with 2 updates: [google.golang.org/grpc](https://github.com/grpc/grpc-go) and google.golang.org/protobuf. Updates `google.golang.org/grpc` from 1.83.1 to 1.83.2 - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.83.1...v1.83.2) Updates `google.golang.org/protobuf` from 1.36.11 to 1.36.12 --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.83.2 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: grpc-protobuf - dependency-name: google.golang.org/protobuf dependency-version: 1.36.12 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: grpc-protobuf ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
Member
|
Superseded by #211, which bundles this with the companion module bump so both Go modules move together. Dependabot tracks |
Contributor
Author
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
dependabot
Bot
deleted the
dependabot/go_modules/gen/go/grpc-protobuf-8bbf612ffe
branch
September 2, 2026 18:03
pdettori
added a commit
that referenced
this pull request
Sep 2, 2026
…Go modules Bundles Dependabot PRs #209 and #210 into a single update. Dependabot tracks /gen/go and /remote-worker as independent directories, so it opens one PR per module. That cannot work here: remote-worker consumes gen/go via a `replace` directive, and the `proto` CI job builds both modules in the same job. #210 (gen/go -> protobuf 1.36.12) therefore left remote-worker/go.mod pinning the stale indirect versions, and the job failed with "updates to go.mod needed; to update it: go mod tidy". This commit bumps both modules together and tidies remote-worker so the indirect protobuf/x-net/x-text versions match gen/go. - google.golang.org/grpc 1.83.1 -> 1.83.2 (security: reject requests missing both :authority and Host headers, grpc/grpc-go#9365) - google.golang.org/protobuf 1.36.11 -> 1.36.12 - golang.org/x/net 0.57.0 -> 0.58.0 (indirect) - golang.org/x/text 0.40.0 -> 0.41.0 (indirect) Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
pdettori
added a commit
that referenced
this pull request
Sep 2, 2026
…y green `remote-worker` consumes `gen/go` through a local `replace`, and the `proto` job builds both modules. Dependabot opens one PR per `go.mod`, so any bump to a `gen/go` dependency left `remote-worker/go.mod` pinning stale indirect versions and CI failed with `go: updates to go.mod needed`. Dependabot cannot fix that itself -- the tidy has to land in the same commit as the bump, and its branches are not maintainer-writable -- so #210 had to be bundled by hand into #211. Add a root `go.work` covering both modules. In workspace mode the go command resolves one MVS across them, so a stale consumer `go.mod` no longer breaks the build and the two modules can be bumped independently. Verified against the tree that failed in #210 (`gen/go` bumped, `remote-worker` left at the pre-#211 state): `go vet` and `go test -race` went from `updates to go.mod needed` to passing, with `gen/go` build and tests unaffected. `directories:` (plural) is a shorthand here, not the fix: Dependabot still opens one PR per directory. Bundling would need `group-by: dependency-name`, which is version-updates-only and splits one PR per dependency, so it would leave the security bumps this entry exists for unbundled. It collapses a duplicated `grpc-protobuf` group block, nothing more. `go mod tidy -diff` still reports drift in workspace mode, so it runs as an advisory step. Failing on it would put the coupled bumps back in the red, and neither module is consumed externally -- `gen/go` is reached only through the local `replace` -- so per-module tidiness is hygiene, not correctness. A module left out of the workspace would silently reintroduce the failure, so a blocking step checks every tracked `go.mod` is listed in `go.work`. `remote-worker/Dockerfile` builds from the repo root and now copies `go.work`; without it that build resolves each module alone and would still hit a stale `go.mod`. Closes #212 Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the grpc-protobuf group in /gen/go with 2 updates: google.golang.org/grpc and google.golang.org/protobuf.
Updates
google.golang.org/grpcfrom 1.83.1 to 1.83.2Release notes
Sourced from google.golang.org/grpc's releases.
Commits
030ee8bUpdate version to 1.83.2 (#9375)8668b69cherry-pick #9365 to v1.83.x (#9366)a3e952dcherry-pick #9346 to v1.83.x and update x/net dependency (#9369)58f8fd9Change version to 1.83.2-dev (#9337)Updates
google.golang.org/protobuffrom 1.36.11 to 1.36.12Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions