chore(deps): bump grpc to 1.83.2 and protobuf to 1.36.12 across both Go modules - #211
Merged
pdettori merged 1 commit intoSep 2, 2026
Merged
Conversation
…Go modules Bundles Dependabot PRs rossoctl#209 and rossoctl#210 into a single update. Dependabot tracks /gen/go and /remote-worker as independent directories, so it opens one PR per module. That cannot work here: remote-worker consumes gen/go via a `replace` directive, and the `proto` CI job builds both modules in the same job. rossoctl#210 (gen/go -> protobuf 1.36.12) therefore left remote-worker/go.mod pinning the stale indirect versions, and the job failed with "updates to go.mod needed; to update it: go mod tidy". This commit bumps both modules together and tidies remote-worker so the indirect protobuf/x-net/x-text versions match gen/go. - google.golang.org/grpc 1.83.1 -> 1.83.2 (security: reject requests missing both :authority and Host headers, grpc/grpc-go#9365) - google.golang.org/protobuf 1.36.11 -> 1.36.12 - golang.org/x/net 0.57.0 -> 0.58.0 (indirect) - golang.org/x/text 0.40.0 -> 0.41.0 (indirect) Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
This was referenced Sep 2, 2026
pdettori
added a commit
that referenced
this pull request
Sep 2, 2026
…y green `remote-worker` consumes `gen/go` through a local `replace`, and the `proto` job builds both modules. Dependabot opens one PR per `go.mod`, so any bump to a `gen/go` dependency left `remote-worker/go.mod` pinning stale indirect versions and CI failed with `go: updates to go.mod needed`. Dependabot cannot fix that itself -- the tidy has to land in the same commit as the bump, and its branches are not maintainer-writable -- so #210 had to be bundled by hand into #211. Add a root `go.work` covering both modules. In workspace mode the go command resolves one MVS across them, so a stale consumer `go.mod` no longer breaks the build and the two modules can be bumped independently. Verified against the tree that failed in #210 (`gen/go` bumped, `remote-worker` left at the pre-#211 state): `go vet` and `go test -race` went from `updates to go.mod needed` to passing, with `gen/go` build and tests unaffected. `directories:` (plural) is a shorthand here, not the fix: Dependabot still opens one PR per directory. Bundling would need `group-by: dependency-name`, which is version-updates-only and splits one PR per dependency, so it would leave the security bumps this entry exists for unbundled. It collapses a duplicated `grpc-protobuf` group block, nothing more. `go mod tidy -diff` still reports drift in workspace mode, so it runs as an advisory step. Failing on it would put the coupled bumps back in the red, and neither module is consumed externally -- `gen/go` is reached only through the local `replace` -- so per-module tidiness is hygiene, not correctness. A module left out of the workspace would silently reintroduce the failure, so a blocking step checks every tracked `go.mod` is listed in `go.work`. `remote-worker/Dockerfile` builds from the repo root and now copies `go.work`; without it that build resolves each module alone and would still hit a stale `go.mod`. Closes #212 Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Paolo Dettori <dettori@us.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bundles Dependabot PRs #209 and #210 into a single, coherent update of the
grpc-protobufgroup across both Go modules.google.golang.org/grpcgoogle.golang.org/protobufgolang.org/x/netgolang.org/x/textgrpc 1.83.2 rejects requests missing both
:authorityandHostheaders withHTTP 400 (grpc/grpc-go#9365).
Why bundle instead of merging #209 and #210
Dependabot tracks
/gen/goand/remote-workeras independent directories, soit opens one PR per module. That cannot work for this repo:
remote-worker/go.modconsumesgen/goviareplace github.com/kagenti/serverless-harness/gen/go => ../gen/goprotoCI job builds both modules in the same jobSo #210 (which bumps
gen/goto protobuf 1.36.12) leftremote-worker/go.modpinning the stale indirect versions, and the"Build and test remote-worker" step failed:
Merging #209 first does not help — it bumps remote-worker's grpc/x-net/x-text
but leaves
protobuf v1.36.11 // indirect, which #210 then invalidates. #210fails after a rebase too, and Dependabot branches cannot be pushed to.
This PR bumps both modules together and tidies
remote-worker, so the indirectprotobuf/x-net/x-textversions matchgen/go.Validation
The full
protojob was reproduced locally with buf 1.71.0 (same version as CI):buf lintbuf generate+ codegen drift checkgen/go:go build ./... && go test ./...remote-worker:gofmt -l .remote-worker:go vet ./...remote-worker:go test -race ./...go mod tidy -diff(both modules)Follow-up
The per-directory Dependabot layout will break on every future
gen/godependency bump. Tracked separately: collapsing the two
gomodentries into oneusing
directories: [/gen/go, /remote-worker]so thegrpc-protobufgroup spansboth modules.
Supersedes #209 and #210.
Assisted-By: Claude Code