How do I use mando directly, i.e., without a decorator? - Failing tests included…#50
How do I use mando directly, i.e., without a decorator? - Failing tests included…#50SamuelMarks wants to merge 1 commit intorubik:masterfrom SamuelMarks:no_decorator_usage
Conversation
SamuelMarks
commented
Jul 1, 2020
…s decorator); [.editorconfig] Init
|
@SamuelMarks Hi Samuel, thanks for the new test. The main problem with it is that Mando does not recognize the doc format automatically, you have to specify it in the All that said, it appears that there is an issue with NumPy doc parsing. So I'll close this PR in favor of #51. There is no issue with using Mando without decorators, but your test caught some other bug. |
|
@rubik I only used builtins for my code, and the only helper was a little snippet from the official Python documentation. In the meantime I wrote my own solution for this, using the builtin EDIT: Just checked the PR you opened. I don't understand, why not just edit my PR instead of taking my commit? - Unless the goal is to prevent my name from appearing in the list of committors? - In terms of auto-detecting the doctype, that's not too difficult, I can probably whip something up… |
|
Don't worry, your name will appear in the changelog if my PR is merged. It's such a petty reason to bring up, why would you think that when I'm always happy to receive PRs and I merge almost all of them? I cannot edit your PR, it's in your fork. And there were too many changes to list them out so I did them directly in this repository. The builtins are not the issue, it was that the test code was unreadable and complex to reason about. Which is why initially I didn't see the issue. By rewriting it I was able to clearly understand that there was no problem with using Mando programmatically, which was the original reason this PR was opened, but that it was all working fine except possibly the NumPy docs parsing. |