Skip to content

gate std_float f16 tests - #544

Merged
programmerjake merged 2 commits into
rust-lang:masterfrom
folkertdev:gate-std-float-f16-tests
Jul 29, 2026
Merged

programmerjake merged 2 commits into
rust-lang:masterfrom
folkertdev:gate-std-float-f16-tests

Conversation

@folkertdev

Copy link
Copy Markdown
Contributor

turns out cranelift needs this too. I've also added a test run for x86_64-pc-windows-gnu which would have caught this much earlier.

@programmerjake programmerjake left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

until the CI issue is resolved I don't think we should merge this.

View changes since this review

Comment thread .github/workflows/ci.yml
@folkertdev
folkertdev force-pushed the gate-std-float-f16-tests branch 4 times, most recently from 8a34525 to 123de4a Compare July 29, 2026 19:13
@programmerjake
programmerjake self-requested a review July 29, 2026 19:16
@programmerjake
programmerjake dismissed their stale review July 29, 2026 19:16

looks like CI is now running all the jobs

@folkertdev
folkertdev force-pushed the gate-std-float-f16-tests branch from 123de4a to 4201a4c Compare July 29, 2026 20:03
@folkertdev

Copy link
Copy Markdown
Contributor Author

alright, made it through CI finally.

@programmerjake
programmerjake merged commit 9b1c0d8 into rust-lang:master Jul 29, 2026
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants