Skip to content

gate std_float f16 tests #544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
programmerjake merged 2 commits into from
Jul 29, 2026
Merged

gate std_float f16 tests #544

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
002cc4f
test `x86_64-pc-windows-gnu` in CI too
folkertdev Jul 29, 2026
4201a4c
gate `std_float` f16 tests
folkertdev Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
strategy:
fail-fast: false
matrix:
target: [x86_64-pc-windows-msvc, i686-pc-windows-msvc, x86_64-unknown-linux-gnu]
target: [x86_64-pc-windows-msvc, x86_64-pc-windows-gnu, i686-pc-windows-msvc, x86_64-unknown-linux-gnu]
Comment thread
programmerjake marked this conversation as resolved.
# `default` means we use the default target config for the target,
# `native` means we run with `-Ctarget-cpu=native`, and anything else is
# an arg to `-Ctarget-feature`
Expand All @@ -73,6 +73,7 @@ jobs:
# Populate the `matrix.os` field
- { target: x86_64-unknown-linux-gnu, os: ubuntu-latest }
- { target: x86_64-pc-windows-msvc, os: windows-latest }
- { target: x86_64-pc-windows-gnu, os: windows-latest }
- { target: i686-pc-windows-msvc, os: windows-latest }

# Annoyingly, the x86_64-unknown-linux-gnu runner *almost* always has
Expand Down
2 changes: 1 addition & 1 deletion crates/core_simd/tests/f16_ops.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
#![feature(f16)]
#![expect(internal_features)]
#![feature(cfg_target_has_reliable_f16_f128)]

#![allow(unused_features)]
#[macro_use]
mod ops_macros;

Expand Down
8 changes: 8 additions & 0 deletions crates/std_float/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,11 @@ wasm-bindgen-test = "0.3"
[features]
default = ["as_crate"]
as_crate = []

[lints.rust.unexpected_cfgs]
level = "warn"
check-cfg = [
# Internal features aren't marked known config by default, we use these to
# gate tests.
'cfg(target_has_reliable_f16_math)',
]
4 changes: 4 additions & 0 deletions crates/std_float/tests/float.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
#![feature(portable_simd)]
#![feature(f16)]
#![feature(cfg_target_has_reliable_f16_f128)]
#![allow(internal_features)]
#![allow(unused_features)]

macro_rules! unary_test {
{ $scalar:tt, $($func:tt),+ } => {
Expand Down Expand Up @@ -87,6 +90,7 @@ macro_rules! impl_tests {
}
}

#[cfg(target_has_reliable_f16_math)]
impl_tests! { f16 }
impl_tests! { f32 }
impl_tests! { f64 }
Loading