Fix next-solver ICE on PointeeSized goals by TaKO8Ki · Pull Request #151962 · rust-lang/rust

TaKO8Ki · 2026-02-01T17:25:31Z

Fixes #151957

rustbot · 2026-02-01T17:25:35Z

rustbot has assigned @mati865.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tests/ui/cycle-trait/pointee-sized-next-solver-ice.rs

mati865 · 2026-02-03T12:03:33Z

@rustbot reroll

TaKO8Ki · 2026-02-17T17:05:50Z

r? compiler

jieyouxu · 2026-02-18T03:17:13Z

r? types

theemathas · 2026-02-18T03:35:07Z

I think this fixes the wrong problem, since the ICE can also occur outside the next-solver. See #151957 (comment)

rperier · 2026-02-18T09:46:21Z

We should not reach this point, self.predicate_must_hold_modulo_regions(...) should not being called. After investigation, there is a false positive match between PointeeSized from the current crate and core::marker::PointeeSized . The problem being, we could have exactly the same issue with some other traits in core::marker::* (like Unsize . I mean some false positives matches without ICE)

lcnr · 2026-03-02T08:22:59Z

tests/ui/cycle-trait/pointee-sized-next-solver-ice.rs

+    <T as PointeeSized>::Undefined: PointeeSized,
+//~^ ERROR the trait bound `T: PointeeSized` is not satisfied
+//~| ERROR the trait bound `T: PointeeSized` is not satisfied
+{}


i personally prefer this reproducer as a test #151957 (comment)

trait PointeeSized {} fn require_trait<T: PointeeSized>() {} fn main() { require_trait::<i32>(); }

please also explain why this errors (and add revisions to test with both solvers)

lcnr

nit wrt the test, otherwise r=me

View changes since this review

lcnr · 2026-03-02T08:41:34Z

compiler/rustc_trait_selection/src/error_reporting/traits/fulfillment_errors.rs

                && trait_name == self.tcx.item_name(def_id)
                && trait_has_same_params(*def_id)
+                // Skip `PointeeSized` here to avoid creating `PointeeSized` solver obligations during error reporting.
+                && !self.tcx.is_lang_item(*def_id, LangItem::PointeeSized)


actually, doesn't really matter, but looking at #153100, it would be more correct to consider PointeeSized to always hold, instead of ignoring it. Don't think that's useful information for users, but 🤷

remove *

rustbot · 2026-03-02T09:02:57Z

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

TaKO8Ki · 2026-03-02T09:05:17Z

@bors r=lcnr

rust-bors · 2026-03-02T09:05:20Z

📌 Commit ca74063 has been approved by lcnr

It is now in the queue for this repository.

…ice, r=lcnr Fix next-solver ICE on PointeeSized goals Fixes rust-lang#151957

…uwer Rollup of 5 pull requests Successful merges: - #151962 (Fix next-solver ICE on PointeeSized goals) - #153161 (Rejig `rustc_with_all_queries!`) - #152164 (Lint unused features) - #153191 ( don't emit `unused_results` lint for tuples of "trivial" types ) - #153273 (vec/mod.rs: add missing period in "ie." in docs)

…ice, r=lcnr Fix next-solver ICE on PointeeSized goals Fixes rust-lang#151957

…uwer Rollup of 9 pull requests Successful merges: - #153153 (add tests for thumb interworking) - #149328 (Add `String<A>` type with custom allocator parameter) - #151780 (Updated slice tests to pass for big endian hosts for `multiple-option-or-permutations.rs`) - #151962 (Fix next-solver ICE on PointeeSized goals) - #153015 (core: make atomic primitives type aliases of `Atomic<T>`) - #153161 (Rejig `rustc_with_all_queries!`) - #153191 ( don't emit `unused_results` lint for tuples of "trivial" types ) - #153273 (vec/mod.rs: add missing period in "ie." in docs) - #153292 (tests: codegen-llvm: vec-calloc: do not require the uwtable attribute)

…ice, r=lcnr Fix next-solver ICE on PointeeSized goals Fixes rust-lang#151957

…uwer Rollup of 11 pull requests Successful merges: - #153153 (add tests for thumb interworking) - #149328 (Add `String<A>` type with custom allocator parameter) - #151780 (Updated slice tests to pass for big endian hosts for `multiple-option-or-permutations.rs`) - #151962 (Fix next-solver ICE on PointeeSized goals) - #153015 (core: make atomic primitives type aliases of `Atomic<T>`) - #153161 (Rejig `rustc_with_all_queries!`) - #153191 ( don't emit `unused_results` lint for tuples of "trivial" types ) - #153273 (vec/mod.rs: add missing period in "ie." in docs) - #153292 (tests: codegen-llvm: vec-calloc: do not require the uwtable attribute) - #153293 (library: std: process: skip tests on Hermit) - #153301 (Do not ping kobzol on rustc-dev-guide changes)

…uwer Rollup of 10 pull requests Successful merges: - #153153 (add tests for thumb interworking) - #151780 (Updated slice tests to pass for big endian hosts for `multiple-option-or-permutations.rs`) - #151962 (Fix next-solver ICE on PointeeSized goals) - #153015 (core: make atomic primitives type aliases of `Atomic<T>`) - #153161 (Rejig `rustc_with_all_queries!`) - #153191 ( don't emit `unused_results` lint for tuples of "trivial" types ) - #153273 (vec/mod.rs: add missing period in "ie." in docs) - #153292 (tests: codegen-llvm: vec-calloc: do not require the uwtable attribute) - #153293 (library: std: process: skip tests on Hermit) - #153301 (Do not ping kobzol on rustc-dev-guide changes)

rustbot assigned mati865 Feb 1, 2026

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 1, 2026

Kivooeo reviewed Feb 1, 2026

View reviewed changes

tests/ui/cycle-trait/pointee-sized-next-solver-ice.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

TaKO8Ki force-pushed the pointee-sized-next-solver-ice branch from 5342488 to 5bd2b85 Compare February 1, 2026 18:22

rustbot assigned SparrowLii and unassigned mati865 Feb 3, 2026

rustbot assigned jieyouxu and unassigned SparrowLii Feb 17, 2026

rustbot added the T-types Relevant to the types team, which will review and decide on the PR/issue. label Feb 18, 2026

rustbot assigned lcnr and unassigned jieyouxu Feb 18, 2026

This comment has been minimized.

Sign in to view

theemathas mentioned this pull request Feb 26, 2026

Do not attempt to evaluate obligations on PointeeSized goals #153100

Closed

lcnr reviewed Mar 2, 2026

View reviewed changes

TaKO8Ki force-pushed the pointee-sized-next-solver-ice branch from 5bd2b85 to 16dae9c Compare March 2, 2026 08:48

This comment has been minimized.

Sign in to view

TaKO8Ki added 3 commits March 2, 2026 17:50

fix next-solver ICE on PointeeSized goals

66786fc

replace issue number with link

6cda9bf

simplify test case and add revisions for both solvers

ca74063

remove *

TaKO8Ki force-pushed the pointee-sized-next-solver-ice branch from 16dae9c to ca74063 Compare March 2, 2026 09:02

rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2026

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 2, 2026

Rollup merge of rust-lang#151962 - TaKO8Ki:pointee-sized-next-solver-…

fe2ef56

…ice, r=lcnr Fix next-solver ICE on PointeeSized goals Fixes rust-lang#151957

JonathanBrouwer mentioned this pull request Mar 2, 2026

Rollup of 4 pull requests #153281

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 2, 2026

Rollup merge of rust-lang#151962 - TaKO8Ki:pointee-sized-next-solver-…

3d91c3e

…ice, r=lcnr Fix next-solver ICE on PointeeSized goals Fixes rust-lang#151957

JonathanBrouwer mentioned this pull request Mar 2, 2026

Rollup of 5 pull requests #153284

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 2, 2026

Rollup merge of rust-lang#151962 - TaKO8Ki:pointee-sized-next-solver-…

052ee84

…ice, r=lcnr Fix next-solver ICE on PointeeSized goals Fixes rust-lang#151957

JonathanBrouwer mentioned this pull request Mar 2, 2026

Rollup of 9 pull requests #153299

Closed

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Mar 2, 2026

Rollup merge of rust-lang#151962 - TaKO8Ki:pointee-sized-next-solver-…

19c321d

…ice, r=lcnr Fix next-solver ICE on PointeeSized goals Fixes rust-lang#151957

JonathanBrouwer mentioned this pull request Mar 2, 2026

Rollup of 11 pull requests #153303

Closed

JonathanBrouwer mentioned this pull request Mar 2, 2026

Rollup of 10 pull requests #153304

Merged

rust-bors bot merged commit 4a3d3cb into rust-lang:main Mar 2, 2026
11 checks passed

rustbot added this to the 1.96.0 milestone Mar 2, 2026

TaKO8Ki deleted the pointee-sized-next-solver-ice branch March 3, 2026 05:31

Uh oh!

Conversation

TaKO8Ki commented Feb 1, 2026 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Feb 1, 2026

Uh oh!

Uh oh!

This comment has been minimized.

mati865 commented Feb 3, 2026

Uh oh!

TaKO8Ki commented Feb 17, 2026

Uh oh!

jieyouxu commented Feb 18, 2026

Uh oh!

theemathas commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rperier commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

lcnr Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

lcnr left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lcnr Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

rustbot commented Mar 2, 2026

Uh oh!

TaKO8Ki commented Mar 2, 2026

Uh oh!

rust-bors bot commented Mar 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

TaKO8Ki commented Feb 1, 2026 •

edited by rustbot

Loading

theemathas commented Feb 18, 2026 •

edited

Loading

rperier commented Feb 18, 2026 •

edited

Loading

lcnr left a comment •

edited by rustbot

Loading