Do not attempt to evaluate obligations on PointeeSized goals#153100
Do not attempt to evaluate obligations on PointeeSized goals#153100KiChjang wants to merge 1 commit intorust-lang:mainfrom
Conversation
|
r? @fmease rustbot has assigned @fmease. Use Why was this reviewer chosen?The reviewer was selected based on:
|
This comment has been minimized.
This comment has been minimized.
b40bc12 to
01292d0
Compare
|
r? @rperier since you have left comments in an earlier PR |
|
Failed to set assignee to
|
|
Note: #151962 already exists |
|
Yeah, I am not a reviewer. I have just wrote the original feature (reporting similarly named traits) :) Could you sync with the author of #151962, or co-author the fix with him perhaps, as there was already a PR opened for this issue. |
|
I unfortunately looked at #151962 first and reviewed that PR already. Your fix for this issue does actually seem more correct, but I would still go with the first one. Thank you for looking into this and opening this PR! |
Fixes #151957.
In this PR, we simply special-case the fulfillment goal if the goal is
PointeeSized, since the trait itself isn't lowered to the trait solver, and all types implement it.