Skip to content

Do not attempt to evaluate obligations on PointeeSized goals#153100

Closed
KiChjang wants to merge 1 commit intorust-lang:mainfrom
KiChjang:special-case-pointee-sized-solver-goals
Closed

Do not attempt to evaluate obligations on PointeeSized goals#153100
KiChjang wants to merge 1 commit intorust-lang:mainfrom
KiChjang:special-case-pointee-sized-solver-goals

Conversation

@KiChjang
Copy link
Contributor

@KiChjang KiChjang commented Feb 25, 2026

Fixes #151957.

In this PR, we simply special-case the fulfillment goal if the goal is PointeeSized, since the trait itself isn't lowered to the trait solver, and all types implement it.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 25, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 25, 2026

r? @fmease

rustbot has assigned @fmease.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 68 candidates
  • Random selection from 14 candidates

@rust-log-analyzer

This comment has been minimized.

@KiChjang KiChjang force-pushed the special-case-pointee-sized-solver-goals branch from b40bc12 to 01292d0 Compare February 25, 2026 19:44
@KiChjang
Copy link
Contributor Author

r? @rperier since you have left comments in an earlier PR

@rustbot
Copy link
Collaborator

rustbot commented Feb 26, 2026

Failed to set assignee to rperier: invalid assignee

Note: Only org members with at least the repository "read" role, users with write permissions, or people who have commented on the PR may be assigned.

@KiChjang
Copy link
Contributor Author

Looks like it's not working, so r? @lcnr instead since you've reviewed the PR made by @rperier in #144674.

@rustbot rustbot assigned lcnr and unassigned fmease Feb 26, 2026
@theemathas
Copy link
Contributor

Note: #151962 already exists

@rperier
Copy link
Contributor

rperier commented Feb 26, 2026

Yeah, I am not a reviewer. I have just wrote the original feature (reporting similarly named traits) :)

Could you sync with the author of #151962, or co-author the fix with him perhaps, as there was already a PR opened for this issue.

@lcnr
Copy link
Contributor

lcnr commented Mar 2, 2026

I unfortunately looked at #151962 first and reviewed that PR already. Your fix for this issue does actually seem more correct, but I would still go with the first one.

Thank you for looking into this and opening this PR!

@lcnr lcnr closed this Mar 2, 2026
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ICE: entered unreachable code: PointeeSized is removed during lowering with -Z next-solver=globally and recursive associated type bound

7 participants