feat(hal): Consolidate per_cpu.rs to use HAL exclusively #84
+310
−577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace all inline assembly in per_cpu.rs with HAL trait calls - Thread management: current_thread, set_current_thread via X86PerCpu - Stack management: kernel_stack_top, set_kernel_stack_top via HAL - Preemption: preempt_disable/enable/count via PerCpuOps trait - Interrupt context: in_interrupt, irq_enter/exit, nmi_enter/exit - Softirq handling: softirq_pending, raise_softirq, clear_softirq - CR3 management: get/set_next_cr3, get/set_kernel_cr3 - Exception cleanup: all context functions via HAL - Add HAL_PERCPU_INITIALIZED boot stage marker - Add HAL_TIMER_CALIBRATED boot stage marker This reduces ~500 lines of inline assembly to HAL calls, improving portability for future ARM64 support while maintaining zero overhead through #[inline(always)] trait methods. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
ryanbreen
force-pushed
the
feature/hal-abstraction-phase2
branch
from
1db69bd to
c32bdcb
Compare
Address validation issues from HAL Phase 2 review: - Add read-back verification in per_cpu::init() to confirm HAL operations work correctly (tests cpu_id and preempt_count read/write cycle) - Consolidate offset constants to single source of truth using offset_of! compile-time assertions against HAL constants - Add debug-only underflow assertions in irq_exit, nmi_exit, softirq_exit - Add compiler fences to irq_enter/irq_exit for consistency with other interrupt context functions - Fix NMI_MASK from 0x3 << 26 (2 bits, wrong) to 0x1 << 26 (1 bit, correct per Linux kernel) - Fix preempt_count bit layout documentation to match actual implementation Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
per_cpu.rsto use HAL trait calls viaX86PerCpuHAL_PERCPU_INITIALIZED,HAL_TIMER_CALIBRATED) for CI validationValidation Fixes (Latest Commit)
Address issues found during technical implementation validation:
HAL Read-back Verification - Added verification in
per_cpu::init()that confirms GS-relative operations work correctly (tests cpu_id and preempt_count cycle)Offset Constant Consolidation - Removed duplicate offset constants, now uses
offset_of!compile-time assertions against HAL constants (13 field assertions)Debug Underflow Assertions - Added debug-only underflow checks in
irq_exit,nmi_exit,softirq_exitCompiler Fence Consistency - Added fences to
irq_enter/irq_exitmatching other interrupt context functionsNMI_MASK Bug Fix - Fixed from
0x3 << 26(2 bits, wrong) to0x1 << 26(1 bit, correct per Linux kernel)Documentation Fix - Updated preempt_count bit layout comment to match actual implementation
Changes
per_cpu.rs Consolidation
All per-CPU operations now go through the HAL:
current_thread,set_current_threadkernel_stack_top,set_kernel_stack_toppreempt_disable,preempt_enable,preempt_countin_interrupt,irq_enter/exit,nmi_enter/exitsoftirq_pending,raise_softirq,clear_softirqget/set_next_cr3,get/set_kernel_cr3Boot Stage Markers
HAL_PERCPU_INITIALIZED- Emitted when per-CPU data is initializedHAL_TIMER_CALIBRATED- Emitted when TSC calibration completesTest plan
🤖 Generated with Claude Code