fix: board page not filling viewport height#331
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #326 changed Shell to size via
height: 100%, which requires a definite-height parent chain. The board page wraps Shell in a plaindivwith no height, so the percentage resolved to auto and the whole board grid collapsed to content height — panes hugged the top of the viewport and the bottom bar floated mid-page. Addsh-fullto the board page's wrapper so it spans AppLayout'sflex-1content region, and a regression assertion in the boards-pin-flow e2e that the bottom bar sits at the viewport bottom (verified failing at 516px without the fix, passing with it).