test(e2e): harden below-fold comment spec against parallel-load timeout#78
Merged
Conversation
Full-suite runs intermittently blew the 30s default test budget inside document setup: keyboard.type types 60 paragraphs char-by-char, which took ~18s solo and >30s under parallel-worker CPU contention — the assertion never ran. Switch to keyboard.insertText (one bulk insertion per paragraph; setup now ~2.5s) and set a 60s belt-and-braces budget. Test-only change; no runtime code touched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ESi6dnK3Wc1jYRpZN5qfZA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The PR #77 audit's one finding: the below-fold e2e spec is timing-fragile. A full-suite run reproduced it —
Test timeout of 30000ms exceededinside document setup (keyboard.typetyping 60 paragraphs char-by-char took ~18s solo and >30s under parallel-worker CPU contention), so the assertion never even ran.What
keyboard.type→keyboard.insertText: one bulk insertion per paragraph. Setup drops from ~18s to ~2.5s.test.setTimeout(60_000)as belt-and-braces so future load spikes still can't kill the test during setup.Test-only; no runtime code touched. The test still exercises the real layout path (spacer +
scrollCardIntoView) exactly as before.Validation
🤖 Generated with Claude Code
https://claude.ai/code/session_01ESi6dnK3Wc1jYRpZN5qfZA