Skip to content

test(e2e): harden below-fold comment spec against parallel-load timeout #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sam-powers merged 1 commit into from
Jul 10, 2026
Merged

test(e2e): harden below-fold comment spec against parallel-load timeout #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion e2e/below-fold-comment.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,20 @@ async function setup(page: Page) {
}

test('a comment on the last line of a tall document scrolls fully into view', async ({ page }) => {
// Belt-and-braces: document setup dominates this test's runtime, and under
// parallel-worker load the default 30s budget has been blown before the
// assertion ever ran.
test.setTimeout(60_000);

const editor = await setup(page);

// Fill well past one viewport so there IS empty space below the last card to
// reproduce the bug — a short doc leaves viewport below the anchor already.
// insertText (one bulk insertion per paragraph) instead of keyboard.type:
// char-by-char typing of 60 paragraphs is what blew the test budget.
const lines = 60;
for (let i = 0; i < lines; i++) {
await page.keyboard.type(`Paragraph ${i} — some body text to give the document height.`);
await page.keyboard.insertText(`Paragraph ${i} — some body text to give the document height.`);
if (i < lines - 1) await page.keyboard.press('Enter');
}
await page.waitForTimeout(100);
Expand Down
Loading