Skip to content

Fix figure-mode question text sitting too high #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
season179 merged 1 commit into from
Jul 20, 2026
Merged

Fix figure-mode question text sitting too high #83

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions game/assets/src/questions/QuestionView.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,13 +67,15 @@ export class QuestionView {
// step layout below is untouched.
const figureModel = resolveFigureView(q);
if (figureModel.mode === "figure" && !turn.step) {
makeWrappedLabel(card, q.question_zh, 0, 137, 760, 56, { fontSize: 20, lineHeight: 26 });
makeWrappedLabel(card, q.question_en, 0, 93, 760, 30, {
// Card half-height is 165; keep ~16px pad under the rounded top so
// the ZH line doesn't sit on the stroke.
makeWrappedLabel(card, q.question_zh, 0, 122, 760, 52, { fontSize: 20, lineHeight: 26 });
makeWrappedLabel(card, q.question_en, 0, 82, 760, 30, {
fontSize: 15,
color: PALETTE.sub,
lineHeight: 19,
});
renderFigure(card, figureModel.spec, { x: 0, y: -38, width: 740, height: 190 });
renderFigure(card, figureModel.spec, { x: 0, y: -42, width: 740, height: 190 });
} else {
this.buildProse(card);
}
Expand Down
Loading