Skip to content

Introduce Hardware Revision class - #31

Merged
lumagi merged 43 commits into
mainfrom
hw_revision
Feb 20, 2026
Merged

Introduce Hardware Revision class#31
lumagi merged 43 commits into
mainfrom
hw_revision

Conversation

@lumagi

@lumagi lumagi commented Oct 25, 2025

Copy link
Copy Markdown
Collaborator

This PR introduces a HW revision class to encapsulate all functionality that is dependent on the Shimmer hardware.

@lumagi lumagi mentioned this pull request Oct 25, 2025
Closed
@JongChern

JongChern commented Nov 17, 2025

Copy link
Copy Markdown
Contributor

hi @lumagi any updates on this, just let us know if we can assist

@lumagi

lumagi commented Nov 24, 2025

Copy link
Copy Markdown
Collaborator Author

I'm sorry, I know I'm working slow. I need to test the class and integrate it with the Bluetooth and reader classes.

lumagi and others added 17 commits November 24, 2025 20:54
@lumagi
Add missing future annotations import
c8fe2a3
@lumagi
Remove unused method in HardwareRevision
9e782a8
@lumagi
Move ESensorGroup unique test to separate group
6d6ff57
@lumagi
Add more tests for HW Revision 3
edd0014
@lumagi
Add HardwareRevision to Bluetooth command constructors, reformat
780b35f 
docstrings
@lumagi
Update Bluetooth Command Tests
7e5cdf2
@lumagi
Fix some of the tests
7750d54
@lumagi
Move HardwareVersion into separate module
bac291b
@lumagi
Link the HardwareRevision to the HardwareVersion enum
8c1e574
@lumagi
Update the Bluetooth API to use the new revision class
fd67128
@lumagi
Update revision handling in ShimmerBluetooth
ff4fdeb
@lumagi
Update the BluetoothRequestHandler tests
013da76
@lumagi
Fix HardwareVersion initialization
dd2c3db
@lumagi
Update Bluetooth tests
89314c3
@lumagi
Rewrite Bluetooth commands to use the revision class
491f58c
@lumagi
Rename EFirmwareType to FirmwareType
0df5ffd
@lumagi
Integrate get_firmware_type into FirmwareType enum
6c05c5f
@lumagi lumagi self-assigned this Dec 22, 2025
@lumagi

lumagi commented Dec 22, 2025

Copy link
Copy Markdown
Collaborator Author

@JongChern I think a lot of the heavy lifting is done. I don't know if you can contribute to this PR, but if you'd like you can create the Shimmer3R revision class.

JongChern and others added 3 commits December 25, 2025 14:45
@JongChern
Shimmer3R (#36)
1bb9ee3 
* add 3r support

* Update test_bt_commands.py

* Update test_bt_commands.py

* Update test_bt_commands.py

* Update test_bt_commands.py

* Update test_bt_commands.py

* Update test_bt_commands.py

* Update test_bt_commands.py
@lumagi
Reformat code and optimize imports
e8875f4
@lumagi
Refactor tests
b09b2bf
@JongChern

JongChern commented Jan 22, 2026

Copy link
Copy Markdown
Contributor

hi, @lumagi just checking in to see if you need any assistance on this PR?

@lumagi

lumagi commented Feb 7, 2026

Copy link
Copy Markdown
Collaborator Author

@JongChern Thank you. I had some design issue about the revision and version classes that was bugging me. But I think I found a way I am happy with. The current state is that only the Dock and testing classes now rely on the base functions that I'm trying to replace with the revisions. Once they're gone, the PR should be ready to merge.

@lumagi
lumagi marked this pull request as ready for review February 8, 2026 14:21
@lumagi

lumagi commented Feb 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

@JongChern I think it should be ready. Feel free to review the PR if there's something that you think needs changing.

I mostly removed all the global functions and attributes in pyshimmer.dev.base and pyshimmer.dev.channels. They are now encapsulated in the revisions classes. The Bluetooth API should now work with both revisions. The Dock and Reader APIs still statically rely on revision 3. If you'd like that's something you could support with, automatically determining the correct revision in the Dock and Reader APIs.

@JongChern

JongChern commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

@lumagi there are issues with the pressure/temp sensor for the 3R, maybe related to the issue reported in #37

investigating now

@JongChern

JongChern commented Feb 19, 2026

Copy link
Copy Markdown
Contributor

@lumagi propose fix via https://github.com/seemoo-lab/pyshimmer/pull/39/changes

@JongChern
Update shimmer3r.py (#39)
d5d69e6 
pressure and temp sensor format update
@lumagi
lumagi merged commit 868ad8b into main Feb 20, 2026
8 checks passed
@lumagi
lumagi deleted the hw_revision branch April 18, 2026 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lumagi lumagi

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lumagi @JongChern