Skip to content

Enable preview task checkboxes - #320

Closed
PathGao wants to merge 1 commit into
sftwrdotdev:masterfrom
PathGao:fix/enable-preview-task-checkboxes
Closed

Enable preview task checkboxes#320
PathGao wants to merge 1 commit into
sftwrdotdev:masterfrom
PathGao:fix/enable-preview-task-checkboxes

Conversation

@PathGao

@PathGao PathGao commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

Fixes #319

Comrak emits task checkboxes without the legacy class or data marker, leaving every preview task disabled. This change tags only renderer-confirmed task list items at the Rust boundary, then makes the preview activate only those items.

The toggle now uses the rendered source line rather than DOM checkbox order. It therefore updates the intended unordered, ordered, nested, quoted, and front-matter-bearing task while raw HTML controls and code-fence lookalikes remain inert.

This is stacked after #318 and its predecessors. Merge the predecessor chain first.

Validation

  • npm ci and npm audit (0 vulnerabilities)
  • npm run check (0 errors, 0 warnings)
  • npm test (139 passing)
  • npm run build
  • cargo test (25 passing)
  • Added renderer regressions for unchecked/checked, nested/quoted, raw-HTML, and multiline-wikilink cases.

Post-Deploy Monitoring & Validation

No additional operational monitoring required: rendering stays local and no service, telemetry, or persistent schema changes. Owner: maintainer/reporter; validate by toggling Markdown tasks in preview after merge, including an ordered task and an inert raw HTML checkbox.

Fixes #148.

@PathGao

PathGao commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator Author

@alecdotdev This fixes the current preview task-checkbox regression from #148/#319. It is stacked after #318 and its predecessors; please review in that order.

@PathGao
PathGao force-pushed the fix/enable-preview-task-checkboxes branch from d343f0a to be47232 Compare August 2, 2026 05:43
@PathGao

PathGao commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by native Stack PR #345 (Stack #353). Closing this fork-head PR so #345 is the active review path.

@PathGao PathGao closed this Aug 2, 2026
@PathGao
PathGao deleted the fix/enable-preview-task-checkboxes branch August 2, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preview task checkboxes remain disabled in current Comrak output Checklists no longer work in Preview mode.

1 participant