Gloas fix genesis#9244
Open
eserilev wants to merge 8 commits intosigp:unstablefrom
Open
Conversation
- Fix forkchoice update sending zero-hash head to EL at genesis by reading latest_block_hash from state when the genesis bid hashes are all zeros - Simplify genesis block construction — the genesis block body is empty per spec, remove the incorrect bid-copying logic and body root override in initialize_beacon_state_from_eth1
|
Some required checks have failed. Could you please take a look @eserilev? 🙏 |
mergify
Bot
added
waiting-on-author
dknopik
reviewed
Apr 30, 2026
Member
|
I reverted these changes to pass the spec tests. If this is needed for interop I think the genesis generator might still be wrong? |
2 tasks
jking-aus
added a commit
that referenced
this pull request
Apr 30, 2026
The alpha-7 spec tests expect the Gloas genesis block body to contain the execution payload bid from state. Restores the genesis_block() function and body_root fixup that were removed in PR #9244. The fork choice from_anchor fix (reading latest_block_hash when bid hashes are zero) remains for Kurtosis/external genesis compatibility.
The alpha-7 spec tests expect the Gloas genesis block body to contain the execution payload bid from state. Restores the genesis_block() function and body_root fixup that were removed in PR sigp#9244. The fork choice from_anchor fix (reading latest_block_hash when bid hashes are zero) remains for Kurtosis/external genesis compatibility.
Member
|
Pushed two additional commits:
|
Member
Yeah I think we were correct and this PR makes it work with genesis generator. Not sure if we should merge this? |
Member
|
Feels like genesis generator should just fix its bullshit? |
Member
|
I've opened an issue to fix the genesis generator: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Addressed
Some gloas genesis changes from glam devnet-0 didnt make it into our unstable branch somehow. This is needed to interop at genesis