Skip to content

fix: Potential fix for code scanning alert no. 19: Slice memory allocation with excessive size value #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
skyoo2003 merged 2 commits into from
Apr 20, 2026
Merged

fix: Potential fix for code scanning alert no. 19: Slice memory allocation with excessive size value #9

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7c75083
Potential fix for code scanning alert no. 19: Slice memory allocation…
skyoo2003 Apr 19, 2026
537f681
fix: simplify Recent() guard clauses in LogCollector
skyoo2003 Apr 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions internal/dashboard/logger.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,11 @@ import (
"time"
)

const (
defaultLogCollectorSize = 1000
maxLogCollectorSize = 10000
)

// RequestLog holds details about a single API request.
type RequestLog struct {
Method string `json:"method"`
Expand All @@ -28,6 +33,13 @@ type LogCollector struct {

// NewLogCollector creates a LogCollector that holds at most maxSize entries.
func NewLogCollector(maxSize int) *LogCollector {
if maxSize <= 0 {
maxSize = defaultLogCollectorSize
}
if maxSize > maxLogCollectorSize {
maxSize = maxLogCollectorSize
}

return &LogCollector{
entries: make([]RequestLog, maxSize),
maxSize: maxSize,
Expand All @@ -52,12 +64,12 @@ func (c *LogCollector) Recent(n int) []RequestLog {
c.mu.RLock()
defer c.mu.RUnlock()

if n <= 0 || c.count == 0 {
return []RequestLog{}
}
if n > c.count {
n = c.count
}
if n <= 0 {
return []RequestLog{}
}

result := make([]RequestLog, n)
// cursor points to the slot that will be written next, so cursor-1 is the
Expand Down
Loading