fix: add bundled S3 platform link dependencies - #5
Open
smaheshwar-pltr wants to merge 2 commits into
Open
smaheshwar-pltr wants to merge 2 commits into
smaheshwar-pltr wants to merge 2 commits into
Conversation
Closed
smaheshwar-pltr
force-pushed
the
fix-cmake-config-s3-deps
branch
from
September 6, 2026 22:05
c6ad762 to
a390bcf
Compare
smaheshwar-pltr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Propagate
ICEBERG_AWSSDK_BUNDLEDinto the installed CMake package config and attach the required macOS and Windows system libraries toArrow::arrow_bundled_dependencieswhen the AWS SDK is bundled.Why
Arrow's bundled AWS libraries depend on platform libraries that were absent from iceberg-cpp's reconstructed imported target. Static consumers could build iceberg-cpp but fail when linking against the installed package. System-AWS-SDK builds are unaffected.
The library lists match Apache Arrow 25.0.0's
ArrowConfig.cmake.in.Closes #9.
Validation
The full GitHub Actions matrix passed, including bundled and system AWS SDK builds.
AI assistance: Codex was used to rebase and review the existing change against current main and Arrow 25.0.0. I reviewed the resulting diff and validation.