Skip to content

fix: add bundled S3 platform link dependencies #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
smaheshwar-pltr wants to merge 2 commits into
base: main
Choose a base branch
from
+26 −0
Open

fix: add bundled S3 platform link dependencies #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a390bcf
fix: add bundled S3 platform link dependencies
smaheshwar-pltr Sep 6, 2026
75a3443
fix: guard links on bundled AWS SDK
smaheshwar-pltr Sep 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions src/iceberg/iceberg-config.cmake.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
@PACKAGE_INIT@

set(ICEBERG_BUILD_STATIC "@ICEBERG_BUILD_STATIC@")
set(ICEBERG_AWSSDK_BUNDLED "@ICEBERG_AWSSDK_BUNDLED@")
set(ICEBERG_SYSTEM_DEPENDENCIES "@ICEBERG_SYSTEM_DEPENDENCIES@")

# Extra args forwarded to find_dependency() for specific dependencies.
Expand Down Expand Up @@ -102,6 +103,31 @@ if(TARGET iceberg::arrow_static)
"${arrow_lib_dir}/${CMAKE_STATIC_LIBRARY_PREFIX}arrow_bundled_dependencies${CMAKE_STATIC_LIBRARY_SUFFIX}"
)
endforeach()

# Arrow's bundled AWS libraries require platform-specific system libraries.
if(ICEBERG_AWSSDK_BUNDLED)
if(APPLE)
find_library(CORE_FOUNDATION CoreFoundation)
target_link_libraries(Arrow::arrow_bundled_dependencies
INTERFACE ${CORE_FOUNDATION})
find_library(SECURITY Security)
target_link_libraries(Arrow::arrow_bundled_dependencies
INTERFACE ${SECURITY})
find_library(NETWORK Network)
target_link_libraries(Arrow::arrow_bundled_dependencies
INTERFACE ${NETWORK})
elseif(WIN32)
target_link_libraries(Arrow::arrow_bundled_dependencies
INTERFACE "winhttp.lib"
"bcrypt.lib"
"wininet.lib"
"userenv.lib"
"version.lib"
"ncrypt.lib"
"Secur32.lib"
"Shlwapi.lib")
endif()
endif()
endif()

if(TARGET iceberg::parquet_static)
Expand Down
Loading