Compiler warning fix#77
Draft
7415963987456321 wants to merge 5 commits into
Draft
Conversation
This was referenced Dec 2, 2020
Contributor
|
These look good, the windows crosspile failed on an unrelated issue. |
Contributor
|
This seems useful. |
Contributor
|
This seems like a very useful fix - the errors were a bit overwhelming... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes several compiler warning in order to reduce logspam.
The compiler was complaining about unused variables, this was fixed by removing said variable.
The compiler was frequently yelling about uninitialized structs, this was fixed by refactoring some code and explicitly filling the struct using memset.
The compiler complained about unsigned comparison, the integer that was being used was changed to a size_t.
Some whitespace issues were fixed.
The compiler complained about unknown characters in a regex, this is fixed by using a raw string for the regex.
Part of Lokaverkefni in Rafmyntir along with PRs: #74 #75 #76
HI username: hrs70