-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add preferences.density preset to scale spacing tokens uniformly #127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smur89
wants to merge
1
commit into
main
Choose a base branch
from
feat/issue-50-density-preset-v2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,64 @@ | ||
| // `preferences.density` scales every spacing em-token uniformly so a | ||
| // single knob trades vertical breathing room for fit-on-one-page. | ||
| // Three pages exercise each preset against the same data; visual diff | ||
| // against the default ("comfortable") confirms the multiplier reaches | ||
| // section headings, divider rules, par.spacing, the in-section block | ||
| // above/below tokens, and the header / summary gaps. | ||
|
|
||
| #import "../lib.typ": alta | ||
|
|
||
| #let cv = ( | ||
| basics: ( | ||
| name: "Jane Doe", | ||
| label: "Senior Software Engineer", | ||
| summary: [Backend engineer; the summary block exercises the | ||
| pre/post `v()` gaps that flank it.], | ||
| email: "jane@example.com", | ||
| phone: "+353 1 555 0100", | ||
| location: "Dublin, Ireland", | ||
| ), | ||
| work: ( | ||
| ( | ||
| name: "Acme Corp", | ||
| position: "Senior Software Engineer", | ||
| location: "Dublin, Ireland", | ||
| startDate: "Jan 2022", | ||
| highlights: ([Led the migration.], [Designed the platform.]), | ||
| ), | ||
| ( | ||
| name: "Foo Ltd", | ||
| position: "Software Engineer", | ||
| startDate: "Jan 2018", | ||
| endDate: "Dec 2021", | ||
| highlights: ([Shipped the thing.],), | ||
| ), | ||
| ), | ||
| skills: ( | ||
| (name: "Languages", keywords: ("Scala", "Python")), | ||
| (name: "Infra", keywords: ("Kafka", "AWS", "Kubernetes")), | ||
| ), | ||
| languages: ( | ||
| (language: "English", fluency: "Native"), | ||
| (language: "Irish", fluency: "Professional Working"), | ||
| ), | ||
| education: ( | ||
| (institution: "Example U", studyType: "B.Sc.", endDate: "2017"), | ||
| ), | ||
| certificates: ( | ||
| (name: "CKA", issuer: "CNCF"), | ||
| ), | ||
| ) | ||
|
|
||
| // 1. Compact — em spacing tokens × 0.85. Tighter than the default. | ||
| #alta(cv, preferences: (density: "compact")) | ||
|
|
||
| #pagebreak() | ||
|
|
||
| // 2. Comfortable — em spacing tokens × 1.0. The default; explicit | ||
| // here so the regression is anchored even if the default changes. | ||
| #alta(cv, preferences: (density: "comfortable")) | ||
|
|
||
| #pagebreak() | ||
|
|
||
| // 3. Spacious — em spacing tokens × 1.15. Roomier than the default. | ||
| #alta(cv, preferences: (density: "spacious")) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹 Nitpick | 🔵 Trivial | ⚡ Quick win
Consider adding a projects section to cover the
sections/projects.typspacing fix.The PR objectives mention a latent bug fix in
sections/projects.typwhere hardcoded0.6emspacing now scales with density. The test CV data doesn't include a projects section, so the regression test won't exercise that fix or catch future regressions in project description spacing.📋 Suggested addition to CV data
education: ( (institution: "Example U", studyType: "B.Sc.", endDate: "2017"), ), + projects: ( + ( + name: "Open Source Tool", + description: [Built a CLI tool; exercises the project description spacing that was fixed.], + highlights: ([Released v1.0.],), + ), + ), certificates: ( (name: "CKA", issuer: "CNCF"), ),📝 Committable suggestion
🤖 Prompt for AI Agents