Skip to content

Conversation

@marques-bruno
Copy link
Member

@marques-bruno marques-bruno commented Jun 16, 2020

The sized-deallocation flag was:

  • set in PRIVATE of the target in the binding modules
  • set in the CXX_FLAGS of the Plugin
  • Not set in the tests, which led to compile errors on some setups.

This PR sets the flag in PUBLIC in the Plugin, which propagates to the bindings and the tests.
There should be no side-effects with having it public, except for the fact that you won't have to add it again manually in your plugins that depend on SP3 (such as SofaQtQuickGUI)

@marques-bruno marques-bruno force-pushed the fix_sized_deallocation_tests branch from 3b9f5a5 to 6f31947 Compare June 16, 2020 12:05
@jnbrunet jnbrunet merged commit 5d09740 into sofa-framework:master Jun 17, 2020
@guparan guparan added this to the v20.12 milestone Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants