Skip to content

ADD: sized-deallocation on test targets #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jnbrunet merged 4 commits into from
Jun 17, 2020
Merged

ADD: sized-deallocation on test targets #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6f31947
Making the sized-deallocation compile option public & removing its re…
marques-bruno Jun 16, 2020
af13cc2
Restore sized-deallocation flag in python modules
marques-bruno Jun 17, 2020
d4dd63d
Update CMakeLists.txt
marques-bruno Jun 17, 2020
6e9144e
Update SofaPython3Tools.cmake
marques-bruno Jun 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMake/SofaPython3Tools.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ function(SP3_add_python_module)
)

if ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "Clang")
target_compile_options(${A_TARGET} PRIVATE -fsized-deallocation)
target_compile_options(${A_TARGET} PUBLIC -fsized-deallocation)
endif()

if (NOT "${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC")
Expand Down
2 changes: 1 addition & 1 deletion Plugin/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ set_target_properties(

if (${CMAKE_CXX_COMPILER_ID} MATCHES "Clang")
# Sized deallocaion is not enabled by default under clang after c++14
set(CMAKE_CXX_FLAGS "-fsized-deallocation")
target_compile_options(${PROJECT_NAME} PUBLIC "-fsized-deallocation")
endif ()

if(CMAKE_SYSTEM_NAME STREQUAL Linux)
Expand Down