Conversation
j8xixo12
force-pushed
the
download_nasa_data
branch
from
a42c603 to
fefe6c8
Compare
yungyuc
left a comment
yungyuc
left a comment
There was a problem hiding this comment.
Points to address.
- Keep only one author in copyright header.
- Use full text for BSD license in the copyright header.
- Add docstrings to explain how to use this tool from command line.
modmesh/track/__init__.py
Outdated
| @@ -0,0 +1,13 @@ | |||
| # Copyright (c) 2026, Chun-Shih Chang <austin20463@gmail.com>, | |||
| # Chun-Hsu Lai <as2266317@gmail.com> | |||
There was a problem hiding this comment.
Keep only one author. @j8xixo12 @ThreeMonth03 , you decide who is listed in the copyright header.
modmesh/track/__init__.py
Outdated
| @@ -0,0 +1,13 @@ | |||
| # Copyright (c) 2026, Chun-Shih Chang <austin20463@gmail.com>, | |||
| # Chun-Hsu Lai <as2266317@gmail.com> | |||
| # BSD 3-Clause License, see COPYING | |||
There was a problem hiding this comment.
Use full text for license in the file copyright header.
modmesh/track/dataset.py
Outdated
| Initialize download/load configuration. | ||
| """ | ||
|
|
||
| self.url = "https://techport.nasa.gov/api/file/presignedUrl/380503" |
modmesh/track/__init__.py
Outdated
| # BSD 3-Clause License, see COPYING | ||
|
|
||
| """ | ||
| track: Track nasa flight dataset with Kalman Filter. |
There was a problem hiding this comment.
Add docstrings to explain how to use this tool from command line.
j8xixo12
force-pushed
the
download_nasa_data
branch
from
60c4216 to
91b523b
Compare
| # OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF | ||
| # LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING | ||
| # NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, | ||
| # EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
There was a problem hiding this comment.
@yungyuc I have put the full text of BSD-3 clause license.
| @@ -0,0 +1,38 @@ | |||
| # Copyright (c) 2026, Chun-Shih Chang <austin20463@gmail.com> | |||
There was a problem hiding this comment.
@ThreeMonth03 I put your name as the author!
| track: Track NASA flight dataset with Kalman Filter. | ||
|
|
||
| How to download the dataset: | ||
| PYTHONPATH=. python3 -m modmesh.track.dataset |
There was a problem hiding this comment.
I added the dataset download cli example here.
| "https://techport.nasa.gov/api/file/presignedUrl/380503", | ||
| "DDL-F1_Dataset-20201013.zip", |
There was a problem hiding this comment.
To accommodate different file names for different url. I have modified the NasaDataset to take url and file name as arguments.
3 participants
This PR is derivatived from #684 and adding a downloader for downloading the nasa problem dataset and untar the data.