Install pygnmi==0.8.15 for docker-sonic-mgmt - #28339
Conversation
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Can you push an empty commit to restart build? |
|
This PR has backport request for branch(es): 202505,202511,202605,202608. ---Powered by SONiC BuildBot
|
Signed-off-by: liang-nexthop <liang@nexthop.ai>
7790990 to
bb520fd
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The backport request for branch(es) msft-202608 has been removed from PR description. Removed label(s).... ---Powered by SONiC BuildBot
|
There was a problem hiding this comment.
Pull request overview
This PR updates the docker-sonic-mgmt container build to include the pygnmi Python dependency required by the new native pygnmi-based gNMI client and related sonic-mgmt tests.
Changes:
- Add
pygnmi==0.8.15to theuv pip installpackage list in thedocker-sonic-mgmtimage build.
|
The change is not in 202505 yet. @liang-nexthop, please manually create the cherry pick PR for branch 202505. ---Powered by SONiC BuildBot
|
|
The change is not in 202511 yet. @liang-nexthop, please manually create the cherry pick PR for branch 202511. ---Powered by SONiC BuildBot
|
What: Adds pygnmi==0.8.15 to dockers/docker-sonic-mgmt/Dockerfile.j2. Why: The new native pygnmi-based gNMI client for sonic-mgmt talks gRPC directly to the DUT's gNMI server, replacing the gnmic CLI binary being removed from docker-ptf; that client depends on pygnmi, which isn't currently installed in the docker-sonic-mgmt image. How: Installs the pygnmi Python package in the docker-sonic-mgmt Dockerfile. Testing: CI green (required checks passing); PR approved. Signed-off-by: liang-nexthop <liang@nexthop.ai>
|
Hi — this PR is flagged for cherry-pick to the 202605 branch (
This helps us track readiness and ensures we don't cherry-pick untested changes. Thanks! Comment by @vaibhavhd via automated tooling |
|
This PR has backport request label(s) for branch(es): 202505,202511,202605, but is missing required test information. Please make sure you tick the tested branch(es) in the Tested branch section and provide test evidence (e.g., 202505: <test result>) in the Test result section as well in your PR description. ---Powered by SONiC BuildBot
|
working on it. |
done |
done. |
What: Adds pygnmi==0.8.15 to dockers/docker-sonic-mgmt/Dockerfile.j2. Why: The new native pygnmi-based gNMI client for sonic-mgmt talks gRPC directly to the DUT's gNMI server, replacing the gnmic CLI binary being removed from docker-ptf; that client depends on pygnmi, which isn't currently installed in the docker-sonic-mgmt image. How: Installs the pygnmi Python package in the docker-sonic-mgmt Dockerfile. Testing: CI green (required checks passing); PR approved. Signed-off-by: liang-nexthop <liang@nexthop.ai> Signed-off-by: jackson-micas <jackson@micasnetworks.com>
|
@liang-nexthop — This PR is requested for the 202605 branch but is missing test evidence. To move forward with cherry-pick approval, please:
Also, to help us prioritize correctly, could you clarify: Is this PR a bug fix / regression fix, a new feature, a platform config change, or a dependency/infra update? Understanding the nature of the change helps us triage the cherry-pick queue. Thank you! Review by @vaibhavhd via automated tooling |
Why I did it
The new native
pygnmi-based gNMI client for sonic-mgmt (see sonic-net/sonic-mgmt#26015 and sonic-net/sonic-mgmt#26013) talks gRPC directly to the DUT's gNMI server from the sonic-mgmt orchestrator, replacing thegnmicCLI binary that is being removed fromdocker-ptf. That client depends on thepygnmiPython package, which is not currently installed in thedocker-sonic-mgmtimage.This PR adds
pygnmi==0.8.15to thedocker-sonic-mgmtimage so the new client and the gNMI tests that use it (tests/common/pygnmi_client.py,tests/gnmi/test_pygnmi_client.py) can run.Related to sonic-net/sonic-mgmt#26015
Companion PR: sonic-net/sonic-mgmt#26013
Work item tracking
How I did it
Added
"pygnmi==0.8.15"to theuv pip installpackage list indockers/docker-sonic-mgmt/Dockerfile.j2. The version is pinned for reproducible builds and to match the version validated by the sonic-mgmt changes.How to verify it
Build the docker-sonic-mgmt image:
make target/docker-sonic-mgmt.gz
Confirm the package is present and pinned inside the image:
docker run --rm docker-sonic-mgmt python3 -c "import pygnmi; print(pygnmi.version)" expects 0.8.15
Run the pygnmi client tests from sonic-mgmt (Add native pygnmi MgmtGnmic client and migrate gNMI tests sonic-mgmt#26013) inside the built container and confirm they no longer fail on
import pygnmi.Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Install pygnmi==0.8.15 in docker-sonic-mgmt for the native gNMI test client
Link to config_db schema for YANG module changes
N/A - no YANG/config_db schema changes.
A picture of a cute animal (not mandatory but encouraged)