[202505] Install pygnmi==0.8.15 for docker-sonic-mgmt - #28690
Open
liang-nexthop wants to merge 1 commit into
Open
liang-nexthop wants to merge 1 commit into
liang-nexthop wants to merge 1 commit into
Conversation
What: Adds pygnmi==0.8.15 to dockers/docker-sonic-mgmt/Dockerfile.j2. Why: The new native pygnmi-based gNMI client for sonic-mgmt talks gRPC directly to the DUT's gNMI server, replacing the gnmic CLI binary being removed from docker-ptf; that client depends on pygnmi, which isn't currently installed in the docker-sonic-mgmt image. How: Installs the pygnmi Python package in the docker-sonic-mgmt Dockerfile. Testing: CI green (required checks passing); PR approved. Signed-off-by: liang-nexthop <liang@nexthop.ai> (cherry picked from commit 86b830a) Signed-off-by: Liang Chen <liang@nexthop.ai>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
12 tasks
Contributor
Author
|
suggested here #28339, @yejianquan can you take a look at this backport PR please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual cherry-pick of #28339 to 202505 (automated cherry-pick conflicted: 202505's docker-sonic-mgmt still uses the
python3 -m pip installpackage list, master usesuv pip install). Change applied into the python3 install block; python2 block untouched (pygnmi is py3-only).Why I did it
sonic-mgmt is migrating gNMI tests to a native pygnmi client (sonic-net/sonic-mgmt#26013); docker-sonic-mgmt needs the library preinstalled.
How I did it
git cherry-pick -x 86b830af0c, resolved the pip-block conflict by insertingpygnmi==0.8.15into the python3 package list.How to verify it
tests/gnmi/test_pygnmi_client.py(20 tests) run with pygnmi 0.8.15 from docker-sonic-mgmt : 20/20 PASS.