Add a multi-dimensional PixelFrame#461
Draft
Cadair wants to merge 1 commit into
Draft
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #461 +/- ##
==========================================
+ Coverage 87.58% 87.66% +0.08%
==========================================
Files 22 22
Lines 3955 3908 -47
==========================================
- Hits 3464 3426 -38
+ Misses 491 482 -9 ☔ View full report in Codecov by Sentry. |
Cadair
force-pushed
the
add_pixel_frame
branch
from
January 6, 2025 10:56
335619d to
2d6ee0d
Compare
WilliamJamieson
force-pushed
the
add_pixel_frame
branch
from
January 7, 2025 15:39
2d6ee0d to
4213953
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I often find myself doing
cf.CoordinateFrame(3, ["PIXEL", "PIXEL", "PIXEL"], unit=[u.pix, u.pix, u.pix], ...)to generate an input frame to a single stage "pixel to world" type WCS.Having a shortcut, designed to be an input frame where you aren't going to have a compound frame or anything as input, like this
PixelFramewould let you doPixelFrame(3)and get the same result.I do think that
Frame2Dfeels somewhat like a special case of this newPixelFrame, but not sure if it's worth deprecatingFrame2Dor not.